Issue 7890031: Mark variables as being accessed from any inner scope, not only function scopes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7890031: Mark variables as being accessed from any inner scope, not only function scopes (Closed)

Created:
9 years, 3 months ago by Steven

Modified:
9 years, 3 months ago

Reviewers:
Kevin Millikin (Chromium), Rico

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Mark variables as being accessed from any inner scope, not only function scopes BUG=96523 TEST=mjsunit/regress/regress-96523.js Committed: http://code.google.com/p/v8/source/detail?r=9281

Patch Set 1 #

Total comments: 2

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -15 lines)			Patch
M	src/scopes.cc	View	8 chunks	+9 lines, -9 lines	2 comments	Download
M	src/variables.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/variables.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A	test/mjsunit/regress/regress-96523.js	View	1 chunk	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Steven

PTAL. http://codereview.chromium.org/7890031/diff/1/src/scopes.cc File src/scopes.cc (left): http://codereview.chromium.org/7890031/diff/1/src/scopes.cc#oldcode855 src/scopes.cc:855: is_function_scope() || from_inner_function, The important change.

9 years, 3 months ago (2011-09-14 13:30:17 UTC) #1

Rico

9 years, 3 months ago (2011-09-14 13:43:25 UTC) #2

LGTM with nit

http://codereview.chromium.org/7890031/diff/1/src/scopes.cc
File src/scopes.cc (right):

http://codereview.chromium.org/7890031/diff/1/src/scopes.cc#newcode853
src/scopes.cc:853: var = outer_scope_->LookupRecursive(
now fits on one line

Expand Messages | Collapse Messages