Issue 7890028: Force lazy deoptimization and remove optimized code on deopt inside a recursively invoked function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7890028: Force lazy deoptimization and remove optimized code on deopt inside a recursively invoked function. (Closed)

Created:
9 years, 3 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 3 months ago

Reviewers:
Søren Thygesen Gjesse, fschneider

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Force lazy deoptimization and remove optimized code on deopt inside a recursively invoked function. R=fschneider@chromium.org,sgjesse@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9285

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	src/runtime.cc	View		3 chunks	+2 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

fschneider

I don't understand why this was a RUNTIME_ASSERT before. Søren, do you remember why that ...

9 years, 3 months ago (2011-09-14 13:10:26 UTC) #2

Søren Thygesen Gjesse

9 years, 3 months ago (2011-09-14 14:26:03 UTC) #3

LGTM

I discussed the assert earlier today with Vyacheslav, and don't see any problem
in removing it.