Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 7890013: Cleanup OWNERS file for the Safe Browsing Folder... (Closed)

Created:
9 years, 3 months ago by MAD
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Cleanup OWNERS file for the Safe Browsing Folder BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101137

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/safe_browsing/OWNERS View 1 2 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
MAD
As discussed over email... Also adding noelutz@ as an owner of this folder... BYE MAD
9 years, 3 months ago (2011-09-13 18:54:27 UTC) #1
Scott Hess - ex-Googler
LGTM Looping Pawel because I think he was complaining about exactly this test binary recently.
9 years, 3 months ago (2011-09-13 19:18:36 UTC) #2
commit-bot: I haz the power
Can't apply patch for file chrome/browser/safe_browsing/safe_browsing_test.cc. While running patch -p0 --forward --force; patching file chrome/browser/safe_browsing/safe_browsing_test.cc ...
9 years, 3 months ago (2011-09-13 23:04:43 UTC) #3
commit-bot: I haz the power
Can't apply patch for file chrome/browser/safe_browsing/safe_browsing_test.cc. While running patch -p0 --forward --force; patching file chrome/browser/safe_browsing/safe_browsing_test.cc ...
9 years, 3 months ago (2011-09-14 01:07:16 UTC) #4
commit-bot: I haz the power
Try job failure for 7890013-2004 on win for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=55354 Step "update" is always ...
9 years, 3 months ago (2011-09-14 12:45:03 UTC) #5
commit-bot: I haz the power
Try job failure for 7890013-2004 on linux_clang for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clang&number=8382 Step "update" is always ...
9 years, 3 months ago (2011-09-14 20:01:58 UTC) #6
MAD
9 years, 3 months ago (2011-09-14 20:19:09 UTC) #7
I think I'll just manually commit... The bot doesn't seem to like this
change... :-/

On Wed, Sep 14, 2011 at 4:01 PM, <commit-bot@chromium.org> wrote:

> Try job failure for 7890013-2004 on linux_clang for step "update".
> http://build.chromium.org/p/**tryserver.chromium/**
>
buildstatus?builder=linux_**clang&number=8382<http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clang&number=8382>
>
> Step "update" is always a major failure.
> Look at the try server FAQ for more details.
>
>
http://codereview.chromium.**org/7890013/<http://codereview.chromium.org/7890...
>

Powered by Google App Engine
This is Rietveld 408576698