Issue 7890003: Fix parent of the WeakMap prototype.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7890003: Fix parent of the WeakMap prototype. (Closed)

Created:
9 years, 3 months ago by Michael Starzinger

Modified:
9 years, 3 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix parent of the WeakMap prototype. R=rossberg@chromium.org BUG=v8:1565 TEST=mjsunit/harmony/weakmaps Committed: http://code.google.com/p/v8/source/detail?r=9254

Patch Set 2 : Correct fix. #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	src/weakmap.js	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
	M	test/mjsunit/harmony/weakmaps.js	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rossberg

LGTM http://codereview.chromium.org/7890003/diff/1/test/mjsunit/harmony/weakmaps.js File test/mjsunit/harmony/weakmaps.js (right): http://codereview.chromium.org/7890003/diff/1/test/mjsunit/harmony/weakmaps.js#newcode160 test/mjsunit/harmony/weakmaps.js:160: // Regression test: The parent of the WeakMap ...

9 years, 3 months ago (2011-09-13 09:27:37 UTC) #2

Michael Starzinger

Had to use a different approach because for experimental natives we cannot use isolate->initial_object_prototype(). http://codereview.chromium.org/7890003/diff/1/test/mjsunit/harmony/weakmaps.js ...

9 years, 3 months ago (2011-09-13 09:38:41 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 7890003: Fix parent of the WeakMap prototype. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Correct fix. #

Messages