Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/hydrogen.cc

Issue 7890002: Reapply "Clean up Context::Lookup and its uses." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/contexts.cc ('k') | src/runtime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4906 matching lines...) Expand 10 before | Expand all | Expand 10 after
4917 return; 4917 return;
4918 4918
4919 } else { 4919 } else {
4920 HValue* context = environment()->LookupContext(); 4920 HValue* context = environment()->LookupContext();
4921 call = PreProcessCall( 4921 call = PreProcessCall(
4922 new(zone()) HCallNamed(context, name, argument_count)); 4922 new(zone()) HCallNamed(context, name, argument_count));
4923 } 4923 }
4924 4924
4925 } else { 4925 } else {
4926 VariableProxy* proxy = expr->expression()->AsVariableProxy(); 4926 VariableProxy* proxy = expr->expression()->AsVariableProxy();
4927 // FIXME.
4928 bool global_call = proxy != NULL && proxy->var()->IsUnallocated(); 4927 bool global_call = proxy != NULL && proxy->var()->IsUnallocated();
4929 4928
4930 if (global_call) { 4929 if (global_call) {
4931 Variable* var = proxy->var(); 4930 Variable* var = proxy->var();
4932 bool known_global_function = false; 4931 bool known_global_function = false;
4933 // If there is a global property cell for the name at compile time and 4932 // If there is a global property cell for the name at compile time and
4934 // access check is not enabled we assume that the function will not change 4933 // access check is not enabled we assume that the function will not change
4935 // and generate optimized code for calling the function. 4934 // and generate optimized code for calling the function.
4936 LookupResult lookup; 4935 LookupResult lookup;
4937 GlobalPropertyAccess type = LookupGlobalProperty(var, &lookup, false); 4936 GlobalPropertyAccess type = LookupGlobalProperty(var, &lookup, false);
(...skipping 1876 matching lines...) Expand 10 before | Expand all | Expand 10 after
6814 } 6813 }
6815 } 6814 }
6816 6815
6817 #ifdef DEBUG 6816 #ifdef DEBUG
6818 if (graph_ != NULL) graph_->Verify(); 6817 if (graph_ != NULL) graph_->Verify();
6819 if (allocator_ != NULL) allocator_->Verify(); 6818 if (allocator_ != NULL) allocator_->Verify();
6820 #endif 6819 #endif
6821 } 6820 }
6822 6821
6823 } } // namespace v8::internal 6822 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/contexts.cc ('k') | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698