Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 7889051: Remove 'settings' type from gyp files (Closed)

Created:
9 years, 3 months ago by Evan Martin
Modified:
9 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Remove 'settings' type from gyp files It is not actually supported by gyp; the fact that it works is a bug that I am working on fixing. BUG=96629 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102306

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -28 lines) Patch
M build/linux/system.gyp View 20 chunks +20 lines, -20 lines 0 comments Download
M sandbox/sandbox.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/bzip2/bzip2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/expat/expat.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjpeg/libjpeg.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libpng/libpng.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libwebp/libwebp.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxml/libxml.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxslt/libxslt.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Martin
9 years, 3 months ago (2011-09-14 21:45:15 UTC) #1
Nico
LGTM All the targets you're touch are linux-only, right?
9 years, 3 months ago (2011-09-14 21:49:32 UTC) #2
Evan Martin
On 2011/09/14 21:49:32, Nico wrote: > LGTM > > All the targets you're touch are ...
9 years, 3 months ago (2011-09-14 21:55:40 UTC) #3
Evan Martin
9 years, 3 months ago (2011-09-14 23:30:30 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698