Issue 7889038: Add solaris support to gyp build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7889038: Add solaris support to gyp build. (Closed)

Created:
9 years, 3 months ago by Jakob Kummerow

Modified:
9 years, 3 months ago

Reviewers:
Yang

CC:
v8-dev, noordhuis

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Add solaris support to gyp build. Patch by Ben Noordhuis <info@bnoordhuis.nl>;. I don't have a Solaris box around to test this myself. BUG=v8:1684 Committed: http://code.google.com/p/v8/source/detail?r=9291

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	build/common.gypi	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	tools/gyp/v8.gyp	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

Yang: take a quick look please. Ben: FYI. Thanks for the patch.

9 years, 3 months ago (2011-09-14 15:41:52 UTC) #1

Yang

9 years, 3 months ago (2011-09-14 15:49:33 UTC) #2

On 2011/09/14 15:41:52, Jakob wrote:
> Yang: take a quick look please.
> 
> Ben: FYI. Thanks for the patch.

rubberstamped LGTM. Don't have a Solaris box around either :)

Expand Messages | Collapse Messages