Normalizing .dropEffect across platforms (specifically Windows).

Normalizing .dropEffect across platforms (specifically Windows).

R=csilv@chromium.org
BUG=95719
TEST=Make sure no more "worm holes" happen on NTP4.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101031

[Dan Beam, 2011-09-13 08:13:03]

http://codereview.chromium.org/7889002/diff/1/chrome/browser/resources/ntp4/d...
File chrome/browser/resources/ntp4/drag_wrapper.js (right):

http://codereview.chromium.org/7889002/diff/1/chrome/browser/resources/ntp4/d...
chrome/browser/resources/ntp4/drag_wrapper.js:111: this.handler_.doDragLeave(e);
This isn't super related to this commit, I just noticed that the event for a
'dragleave' wasn't being passed along as a @param to TilePage#doDragLeave.

[csilv, 2011-09-13 18:57:24]

http://codereview.chromium.org/7889002/diff/1/chrome/browser/resources/ntp4/t...
File chrome/browser/resources/ntp4/tile_page.js (right):

http://codereview.chromium.org/7889002/diff/1/chrome/browser/resources/ntp4/t...
chrome/browser/resources/ntp4/tile_page.js:161: // HACK(dbeam): Until we fix
dropEffect to the correct behavior it will
Change this to a TODO comment instead.

http://codereview.chromium.org/7889002/diff/1/chrome/browser/resources/ntp4/t...
chrome/browser/resources/ntp4/tile_page.js:943: lastDropEffect_: null,
Is it necessary to do this? (ie, wont the default value of undefined work?)

[Dan Beam, 2011-09-13 22:19:13]

http://codereview.chromium.org/7889002/diff/1/chrome/browser/resources/ntp4/t...
File chrome/browser/resources/ntp4/tile_page.js (right):

http://codereview.chromium.org/7889002/diff/1/chrome/browser/resources/ntp4/t...
chrome/browser/resources/ntp4/tile_page.js:161: // HACK(dbeam): Until we fix
dropEffect to the correct behavior it will
On 2011/09/13 18:57:24, csilv wrote:
> Change this to a TODO comment instead.

Done.

http://codereview.chromium.org/7889002/diff/1/chrome/browser/resources/ntp4/t...
chrome/browser/resources/ntp4/tile_page.js:943: lastDropEffect_: null,
On 2011/09/13 18:57:24, csilv wrote:
> Is it necessary to do this? (ie, wont the default value of undefined work?)

Done.

[csilv, 2011-09-13 22:22:11]

lgtm

[commit-bot: I haz the power, 2011-09-14 04:55:33]

Change committed as 101031