Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3569)

Unified Diff: chrome/browser/extensions/extension_message_service.cc

Issue 7888064: Only deliver extension messages to contexts that care. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nail down a bit further. Only poke relevant RenderView in the case of chrome.tabs.connect(). Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_message_service.cc
diff --git a/chrome/browser/extensions/extension_message_service.cc b/chrome/browser/extensions/extension_message_service.cc
index 57df12ab9f0b0efa2120afc72154dfc7c08d1e45..1fe34552adc702c6e650e862d53de3b380d61018 100644
--- a/chrome/browser/extensions/extension_message_service.cc
+++ b/chrome/browser/extensions/extension_message_service.cc
@@ -50,8 +50,6 @@ const char ExtensionMessageService::kDispatchOnConnect[] =
"Port.dispatchOnConnect";
const char ExtensionMessageService::kDispatchOnDisconnect[] =
"Port.dispatchOnDisconnect";
-const char ExtensionMessageService::kDispatchOnMessage[] =
- "Port.dispatchOnMessage";
namespace {
@@ -88,12 +86,10 @@ static void DispatchOnDisconnect(
}
static void DispatchOnMessage(const ExtensionMessageService::MessagePort& port,
- const std::string& message, int source_port_id) {
- ListValue args;
- args.Set(0, Value::CreateStringValue(message));
- args.Set(1, Value::CreateIntegerValue(source_port_id));
- port.sender->Send(new ExtensionMsg_MessageInvoke(port.routing_id,
- "", ExtensionMessageService::kDispatchOnMessage, args, GURL()));
+ const std::string& message, int target_port_id) {
+ port.sender->Send(
+ new ExtensionMsg_DeliverMessage(
+ port.routing_id, target_port_id, message));
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698