Added Instant preference syncing and tests.

chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/values.h"
 #include "chrome/browser/sync/profile_sync_service_harness.h"
 #include "chrome/browser/translate/translate_prefs.h"
 #include "chrome/browser/sync/test/integration/sync_test.h"
 #include "chrome/browser/sync/test/integration/preferences_helper.h"
 #include "chrome/common/pref_names.h"
@@ skipping 159 matching lines @@
 // TCM ID - 3666296.
 IN_PROC_BROWSER_TEST_F(TwoClientPreferencesSyncTest, kShowBookmarkBar) {
   ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
   ASSERT_TRUE(BooleanPrefMatches(prefs::kShowBookmarkBar));
 
   ChangeBooleanPref(0, prefs::kShowBookmarkBar);
   ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
   ASSERT_TRUE(BooleanPrefMatches(prefs::kShowBookmarkBar));
 }
 
+IN_PROC_BROWSER_TEST_F(TwoClientPreferencesSyncTest, kEnableInstant) {

[csharp, 2011/09/14 20:13:22]

I'm not sure if this test is correctly setup, I just tried to follow the style
of the other tests.
Also, prefs::kInstanceEnabledTime isn't tested because I could find the int64
versions of PrefMatches and Change*Pref, do they exist?

[Nicolas Zea, 2011/09/14 21:32:12]

They do not yet, feel free to add them though. See
chrome/browser/sync/test/integration/preferences_helper.[h,cc] for examples

[csharp, 2011/09/15 13:39:12]

They have been added.

On 2011/09/14 21:32:12, nzea wrote:

+  ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
+  ASSERT_TRUE(BooleanPrefMatches(prefs::kInstantConfirmDialogShown));
+  ASSERT_TRUE(BooleanPrefMatches(prefs::kInstantEnabled));
+  ASSERT_TRUE(BooleanPrefMatches(prefs::kInstantEnabledOnce));
+
+  ChangeBooleanPref(0, prefs::kInstantConfirmDialogShown);
+  ChangeBooleanPref(0, prefs::kInstantEnabled);
+  ChangeBooleanPref(0, prefs::kInstantEnabledOnce);
+
+  ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
+  ASSERT_TRUE(BooleanPrefMatches(prefs::kInstantConfirmDialogShown));
+  ASSERT_TRUE(BooleanPrefMatches(prefs::kInstantEnabled));
+  ASSERT_TRUE(BooleanPrefMatches(prefs::kInstantEnabledOnce));
+}
+
 // TCM ID - 3611311.
 IN_PROC_BROWSER_TEST_F(TwoClientPreferencesSyncTest, kCheckDefaultBrowser) {
   ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
   DisableVerifier();
 
   ASSERT_TRUE(BooleanPrefMatches(
       prefs::kCheckDefaultBrowser));
 
   ChangeBooleanPref(0, prefs::kCheckDefaultBrowser);
   ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
@@ skipping 470 matching lines @@
   ASSERT_TRUE(IsEncrypted(0, syncable::PREFERENCES));
   ASSERT_TRUE(IsEncrypted(1, syncable::PREFERENCES));
   ASSERT_TRUE(BooleanPrefMatches(
       prefs::kHomePageIsNewTabPage));
 
   ASSERT_TRUE(BooleanPrefMatches(prefs::kShowHomeButton));
   ChangeBooleanPref(0, prefs::kShowHomeButton);
   ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
   ASSERT_TRUE(BooleanPrefMatches(prefs::kShowHomeButton));
 }