scm.py - Issue 7888042: Replace check_output() call site into check_call(). Would throw otherwise.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scm.py

Issue 7888042: Replace check_output() call site into check_call(). Would throw otherwise. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scm.py

diff --git a/scm.py b/scm.py

index 446c94add8381b971932c7327c959f0c222f01d1..fa738135b491790209bac6f7f6caba5b60af1752 100644

--- a/scm.py

+++ b/scm.py

@@ -76,7 +76,7 @@ def determine_scm(root):

return 'git'

else:

try:

- subprocess2.check_output(

+ subprocess2.check_call(

['git', 'rev-parse', '--show-cdup'],

stdout=subprocess2.VOID,

stderr=subprocess2.VOID,

« no previous file with comments | « no previous file | no next file » | no next file with comments »