Issue 7888035: Fixed broken readline console history.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7888035: Fixed broken readline console history. (Closed)

Created:
9 years, 3 months ago by Yang

Modified:
9 years, 3 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fixed broken readline console history. Committed: http://code.google.com/p/v8/source/detail?r=9272

Patch Set 1 #

Total comments: 1

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -29 lines)			Patch
	M	src/d8.h	View		3 chunks	+24 lines, -23 lines	1 comment	Download
	M	src/d8.cc	View		3 chunks	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

PTAL. When quitting d8 in an ordered manner (not ^C), a log is saved into ...

9 years, 3 months ago (2011-09-14 07:39:56 UTC) #1

Jakob Kummerow

9 years, 3 months ago (2011-09-14 08:03:04 UTC) #2

LGTM.

http://codereview.chromium.org/7888035/diff/1/src/d8.h
File src/d8.h (right):

http://codereview.chromium.org/7888035/diff/1/src/d8.h#newcode1
src/d8.h:1: // Copyright 2009 the V8 project authors. All rights reserved.
nit: 2011
(probably should've changed that a long time ago...)

Expand Messages | Collapse Messages