Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 7888010: Redirect chrome://extensions to the new chrome://settings/chromeExtensions. (Closed)

Created:
9 years, 3 months ago by Finnur
Modified:
9 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Redirect chrome://extensions to the new chrome://settings/chromeExtensions. The two modifications to the tests were needed because they were trying to open chrome://extensions in incognito. In one case, the test just needed any page (so I switched to about:blank) and in the other we are testing for a condition that cannot happen anymore because chrome://extensions could be loaded in incognito but chrome://settings doesn't allow that -- it shunts the request to the non-incognito profile. The test was testing that we don't crash in incognito, so I removed that test. BUG=87377 TEST=Well... type in chrome://extensions and notice it redirects. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101046

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -19 lines) Patch
M chrome/browser/browser_about_handler.cc View 1 2 1 chunk +12 lines, -3 lines 0 comments Download
M chrome/browser/extensions/browser_action_apitest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_management_browsertest.cc View 1 1 chunk +0 lines, -14 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Finnur
Aaron, please review. Also note that I'm deleting a test you created a while back ...
9 years, 3 months ago (2011-09-13 17:36:46 UTC) #1
Matt Perry
http://codereview.chromium.org/7888010/diff/5002/chrome/browser/extensions/extension_management_browsertest.cc File chrome/browser/extensions/extension_management_browsertest.cc (left): http://codereview.chromium.org/7888010/diff/5002/chrome/browser/extensions/extension_management_browsertest.cc#oldcode150 chrome/browser/extensions/extension_management_browsertest.cc:150: IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, Incognito) { Wow, this test is ancient. I ...
9 years, 3 months ago (2011-09-13 19:00:40 UTC) #2
Aaron Boodman
9 years, 3 months ago (2011-09-14 05:49:52 UTC) #3
lgtm, thanks

Powered by Google App Engine
This is Rietveld 408576698