Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 7887038: Enable inlining of functions that reference context slots. (Closed)

Created:
9 years, 3 months ago by fschneider
Modified:
9 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Enable inlining of functions that reference context slots. Committed: http://code.google.com/p/v8/source/detail?r=9294

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1 line) Patch
M src/ast.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
A test/mjsunit/compiler/inline-context-slots.js View 1 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
fschneider
9 years, 3 months ago (2011-09-14 14:52:41 UTC) #1
William Hesse
I'm not sure that you test the case that f.run has an inner context here. ...
9 years, 3 months ago (2011-09-15 00:07:06 UTC) #2
Kevin Millikin (Chromium)
9 years, 3 months ago (2011-09-15 09:45:01 UTC) #3
LGTM.

http://codereview.chromium.org/7887038/diff/1/src/ast.cc
File src/ast.cc (right):

http://codereview.chromium.org/7887038/diff/1/src/ast.cc#newcode532
src/ast.cc:532: return !var()->IsLookupSlot();
I'd prefer to keep this a whitelist, listing the things that we can support. 
It's too risky that someone will add a new kind of thing that becomes inlinable
without supporting it.

Powered by Google App Engine
This is Rietveld 408576698