Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1143)

Unified Diff: src/full-codegen.cc

Issue 7887037: Nuke CompareToNull AST node. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen.h ('k') | src/hydrogen.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/full-codegen.cc
===================================================================
--- src/full-codegen.cc (revision 9281)
+++ src/full-codegen.cc (working copy)
@@ -244,11 +244,6 @@
}
-void BreakableStatementChecker::VisitCompareToNull(CompareToNull* expr) {
- Visit(expr->expression());
-}
-
-
void BreakableStatementChecker::VisitCompareOperation(CompareOperation* expr) {
Visit(expr->left());
Visit(expr->right());
@@ -1325,6 +1320,7 @@
Label* if_true,
Label* if_false,
Label* fall_through) {
+ bool is_strict = compare->op() == Token::EQ_STRICT;
Expression *expr;
Handle<String> check;
if (compare->IsLiteralCompareTypeof(&expr, &check)) {
@@ -1337,6 +1333,11 @@
return true;
}
+ if (compare->IsLiteralCompareNull(&expr)) {
+ EmitLiteralCompareNull(expr, is_strict, if_true, if_false, fall_through);
+ return true;
+ }
+
return false;
}
« no previous file with comments | « src/full-codegen.h ('k') | src/hydrogen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698