Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 7887037: Nuke CompareToNull AST node. (Closed)

Created:
9 years, 3 months ago by Sven Panne
Modified:
9 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Nuke CompareToNull AST node. The Great Master Plan is to move the recognition of special cases for comparisons further down the compilation pipeline where more information is available. This is a first step into this direction: The special handling of equality comparisons involving null is pushed from the parser to the code generators, removing the need for a special AST node. (There are rumors from usually well-informed sources that this node type is actually a relic of ancient crankshaft days...) The next steps will be the unification of null/undefined handling and pushing the special case handling in crankshaft even further down the pipeline, enabling the recognition of cases like "var foo=null; if (foo === bar) ...", but these will be in separate CLs. Committed: http://code.google.com/p/v8/source/detail?r=9293

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -136 lines) Patch
M src/arm/full-codegen-arm.cc View 2 chunks +7 lines, -12 lines 0 comments Download
M src/ast.h View 3 chunks +1 line, -20 lines 0 comments Download
M src/ast.cc View 2 chunks +21 lines, -5 lines 0 comments Download
M src/full-codegen.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/full-codegen.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M src/hydrogen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +11 lines, -5 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +7 lines, -12 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 2 chunks +7 lines, -12 lines 0 comments Download
M src/parser.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/parser.cc View 2 chunks +1 line, -22 lines 0 comments Download
M src/prettyprinter.cc View 3 chunks +0 lines, -26 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
9 years, 3 months ago (2011-09-14 14:12:54 UTC) #1
fschneider
9 years, 3 months ago (2011-09-15 08:56:01 UTC) #2
LGTM.

I also like the new approach much better.

Powered by Google App Engine
This is Rietveld 408576698