Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/runtime.js

Issue 7887031: Make built-in functions not call .apply on functions. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/execution.cc ('k') | src/string.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 390 matching lines...) Expand 10 before | Expand all | Expand 10 after
401 if (%HasProperty(this, string)) return string; 401 if (%HasProperty(this, string)) return string;
402 return 0; 402 return 0;
403 } 403 }
404 404
405 405
406 function CALL_NON_FUNCTION() { 406 function CALL_NON_FUNCTION() {
407 var delegate = %GetFunctionDelegate(this); 407 var delegate = %GetFunctionDelegate(this);
408 if (!IS_FUNCTION(delegate)) { 408 if (!IS_FUNCTION(delegate)) {
409 throw %MakeTypeError('called_non_callable', [typeof this]); 409 throw %MakeTypeError('called_non_callable', [typeof this]);
410 } 410 }
411 return delegate.apply(this, arguments); 411 return %Apply(delegate, this, arguments, 0, %_ArgumentsLength());
412 } 412 }
413 413
414 414
415 function CALL_NON_FUNCTION_AS_CONSTRUCTOR() { 415 function CALL_NON_FUNCTION_AS_CONSTRUCTOR() {
416 var delegate = %GetConstructorDelegate(this); 416 var delegate = %GetConstructorDelegate(this);
417 if (!IS_FUNCTION(delegate)) { 417 if (!IS_FUNCTION(delegate)) {
418 throw %MakeTypeError('called_non_callable', [typeof this]); 418 throw %MakeTypeError('called_non_callable', [typeof this]);
419 } 419 }
420 return delegate.apply(this, arguments); 420 return %Apply(delegate, this, arguments, 0, %_ArgumentsLength());
421 } 421 }
422 422
423 423
424 function CALL_FUNCTION_PROXY() { 424 function CALL_FUNCTION_PROXY() {
425 var arity = %_ArgumentsLength() - 1; 425 var arity = %_ArgumentsLength() - 1;
426 var proxy = %_Arguments(arity); // The proxy comes in as an additional arg. 426 var proxy = %_Arguments(arity); // The proxy comes in as an additional arg.
427 var trap = %GetCallTrap(proxy); 427 var trap = %GetCallTrap(proxy);
428 return %Apply(trap, this, arguments, 0, arity); 428 return %Apply(trap, this, arguments, 0, arity);
429 } 429 }
430 430
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
668 throw %MakeTypeError('cannot_convert_to_primitive', []); 668 throw %MakeTypeError('cannot_convert_to_primitive', []);
669 } 669 }
670 670
671 671
672 // NOTE: Setting the prototype for Array must take place as early as 672 // NOTE: Setting the prototype for Array must take place as early as
673 // possible due to code generation for array literals. When 673 // possible due to code generation for array literals. When
674 // generating code for a array literal a boilerplate array is created 674 // generating code for a array literal a boilerplate array is created
675 // that is cloned when running the code. It is essential that the 675 // that is cloned when running the code. It is essential that the
676 // boilerplate gets the right prototype. 676 // boilerplate gets the right prototype.
677 %FunctionSetPrototype($Array, new $Array(0)); 677 %FunctionSetPrototype($Array, new $Array(0));
OLDNEW
« no previous file with comments | « src/execution.cc ('k') | src/string.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698