Issue 7887009: [filebrowser] UI improvements in image editor.

Issue 7887009: [filebrowser] UI improvements in image editor. (Closed)

Created:
9 years, 3 months ago by dgozman

Modified:
9 years, 3 months ago

Reviewers:
Vladislav Kaznacheev

CC:
chromium-reviews, Erik does not do reviews, achuith+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[filebrowser] UI improvements in image editor. BUG=chromium-os:19534 TEST=See bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101060

Patch Set 3 : '' #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+140 lines, -44 lines)			Patch
M	chrome/browser/resources/component_extension_resources.grd	View	1	1 chunk	+10 lines, -1 line	0 comments	Download
A	chrome/browser/resources/file_manager/images/gallery/arrow_left.png	View		Binary file		0 comments	Download
A	chrome/browser/resources/file_manager/images/gallery/arrow_left_disabled.png	View		Binary file		0 comments	Download
A	chrome/browser/resources/file_manager/images/gallery/arrow_right.png	View		Binary file		0 comments	Download
A	chrome/browser/resources/file_manager/images/gallery/arrow_right_disabled.png	View		Binary file		0 comments	Download
A	chrome/browser/resources/file_manager/images/gallery/icon_autofix.png	View		Binary file		0 comments	Download
A	chrome/browser/resources/file_manager/images/gallery/icon_autofix_selected.png	View		Binary file		0 comments	Download
A	chrome/browser/resources/file_manager/images/gallery/icon_brightness.png	View		Binary file		0 comments	Download
A	chrome/browser/resources/file_manager/images/gallery/icon_brightness_selected.png	View		Binary file		0 comments	Download
A	chrome/browser/resources/file_manager/images/gallery/icon_crop.png	View		Binary file		0 comments	Download
A	chrome/browser/resources/file_manager/images/gallery/icon_crop_selected.png	View		Binary file		0 comments	Download
A	chrome/browser/resources/file_manager/images/gallery/icon_edit.png	View		Binary file		0 comments	Download
A	chrome/browser/resources/file_manager/images/gallery/icon_edit_selected.png	View		Binary file		0 comments	Download
A	chrome/browser/resources/file_manager/images/gallery/icon_rotate.png	View		Binary file		0 comments	Download
A	chrome/browser/resources/file_manager/images/gallery/icon_rotate_selected.png	View		Binary file		0 comments	Download
A	chrome/browser/resources/file_manager/images/gallery/icon_share.png	View		Binary file		0 comments	Download
A	chrome/browser/resources/file_manager/images/gallery/icon_share_selected.png	View		Binary file		0 comments	Download
A	chrome/browser/resources/file_manager/images/gallery/icon_undo.png	View		Binary file		0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/gallery.css	View		5 chunks	+88 lines, -22 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/gallery.js	View	1	6 chunks	+39 lines, -18 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/image_adjust.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/image_transform.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vladislav Kaznacheev

LGTM with comments. icon_undo_selected.psd is probably an error (should have been png?) http://codereview.chromium.org/7887009/diff/1/chrome/browser/resources/component_extension_resources.grd File chrome/browser/resources/component_extension_resources.grd ...

9 years, 3 months ago (2011-09-14 10:50:39 UTC) #2

dgozman

9 years, 3 months ago (2011-09-14 11:31:30 UTC) #3

Thanks, committing.

http://codereview.chromium.org/7887009/diff/1/chrome/browser/resources/compon...
File chrome/browser/resources/component_extension_resources.grd (right):

http://codereview.chromium.org/7887009/diff/1/chrome/browser/resources/compon...
chrome/browser/resources/component_extension_resources.grd:79: <include
name="IDR_FILE_MANAGER_WARNING_ICON"
file="file_manager/images/warning_icon_square_26x26.png" type="BINDATA"/>
On 2011/09/14 10:50:39, Vladislav Kaznacheev wrote:
> Whitespace?

Done.

http://codereview.chromium.org/7887009/diff/1/chrome/browser/resources/file_m...
File chrome/browser/resources/file_manager/js/image_editor/gallery.js (right):

http://codereview.chromium.org/7887009/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/image_editor/gallery.js:73:
this.editBar_.firstChild.setAttribute('hidden', 'hidden');
On 2011/09/14 10:50:39, Vladislav Kaznacheev wrote:
> Comment what the firstChild really is?

Done.

Expand Messages | Collapse Messages