Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: content/renderer/media/video_capture_module_impl.h

Issue 7887002: Update the Chromium version of webrtc::VideoCaptureModule to be reference counted. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/media/video_capture_module_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/video_capture_module_impl.h
===================================================================
--- content/renderer/media/video_capture_module_impl.h (revision 100680)
+++ content/renderer/media/video_capture_module_impl.h (working copy)
@@ -22,7 +22,10 @@
public:
VideoCaptureModuleImpl(const media::VideoCaptureSessionId id,
VideoCaptureImplManager* vc_manager);
- virtual ~VideoCaptureModuleImpl();
+ // Implement reference counting. This make it possible to reference the
+ // object from both Chromium and WebRtc.
+ virtual int32_t AddRef();
scherkus (not reviewing) 2011/09/13 15:22:58 is this actually an interface that we're implement
perkj_chrome 2011/09/19 11:14:21 Yes- it is part of the interface we are implementi
+ virtual int32_t Release();
// Override webrtc::videocapturemodule::VideoCaptureImpl implementation.
virtual WebRtc_Word32 StartCapture(
@@ -45,6 +48,7 @@
const media::VideoCaptureParams& device_info);
private:
+ virtual ~VideoCaptureModuleImpl();
void Init();
void StartCaptureOnCaptureThread(
@@ -76,6 +80,7 @@
media::VideoCapture* capture_engine_;
bool pending_start_;
webrtc::VideoCaptureCapability pending_cap_;
+ int ref_count_;
DISALLOW_COPY_AND_ASSIGN(VideoCaptureModuleImpl);
};
« no previous file with comments | « no previous file | content/renderer/media/video_capture_module_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698