Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: ppapi/proxy/ppb_buffer_proxy.cc

Issue 7887001: s patch tries to remove most of the manual registration for Pepper interfaces, and replaces it wi... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/ppb_buffer_proxy.h ('k') | ppapi/proxy/ppb_char_set_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/ppb_buffer_proxy.cc
===================================================================
--- ppapi/proxy/ppb_buffer_proxy.cc (revision 100854)
+++ ppapi/proxy/ppb_buffer_proxy.cc (working copy)
@@ -17,20 +17,12 @@
#include "ppapi/proxy/ppapi_messages.h"
#include "ppapi/thunk/enter.h"
#include "ppapi/thunk/ppb_buffer_trusted_api.h"
+#include "ppapi/thunk/resource_creation_api.h"
#include "ppapi/thunk/thunk.h"
namespace ppapi {
namespace proxy {
-namespace {
-
-InterfaceProxy* CreateBufferProxy(Dispatcher* dispatcher,
- const void* target_interface) {
- return new PPB_Buffer_Proxy(dispatcher, target_interface);
-}
-
-} // namespace
-
Buffer::Buffer(const HostResource& resource,
const base::SharedMemoryHandle& shm_handle,
uint32_t size)
@@ -69,27 +61,14 @@
shm_.Unmap();
}
-PPB_Buffer_Proxy::PPB_Buffer_Proxy(Dispatcher* dispatcher,
- const void* target_interface)
- : InterfaceProxy(dispatcher, target_interface) {
+PPB_Buffer_Proxy::PPB_Buffer_Proxy(Dispatcher* dispatcher)
+ : InterfaceProxy(dispatcher) {
}
PPB_Buffer_Proxy::~PPB_Buffer_Proxy() {
}
// static
-const InterfaceProxy::Info* PPB_Buffer_Proxy::GetInfo() {
- static const Info info = {
- thunk::GetPPB_Buffer_Thunk(),
- PPB_BUFFER_DEV_INTERFACE,
- INTERFACE_ID_PPB_BUFFER,
- false,
- &CreateBufferProxy,
- };
- return &info;
-}
-
-// static
PP_Resource PPB_Buffer_Proxy::CreateProxyResource(PP_Instance instance,
uint32_t size) {
PluginDispatcher* dispatcher = PluginDispatcher::GetForInstance(instance);
@@ -135,10 +114,15 @@
HostDispatcher* dispatcher = HostDispatcher::GetForInstance(instance);
if (!dispatcher)
return;
- PP_Resource local_buffer_resource =
- ppb_buffer_target()->Create(instance, size);
+
+ thunk::EnterResourceCreation enter(instance);
+ if (enter.failed())
+ return;
+ PP_Resource local_buffer_resource = enter.functions()->CreateBuffer(instance,
+ size);
if (local_buffer_resource == 0)
return;
+
thunk::EnterResourceNoLock<thunk::PPB_BufferTrusted_API> trusted_buffer(
local_buffer_resource, false);
if (trusted_buffer.failed())
« no previous file with comments | « ppapi/proxy/ppb_buffer_proxy.h ('k') | ppapi/proxy/ppb_char_set_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698