s patch tries to remove most of the manual registration for Pepper interfaces, and replaces it wi...

ppapi/proxy/plugin_dispatcher.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/proxy/plugin_dispatcher.h"
 
 #include <map>
 
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "ipc/ipc_message.h"
 #include "ipc/ipc_sync_channel.h"
 #include "base/debug/trace_event.h"
 #include "ppapi/c/pp_errors.h"
+#include "ppapi/proxy/interface_list.h"
 #include "ppapi/proxy/interface_proxy.h"
 #include "ppapi/proxy/plugin_message_filter.h"
 #include "ppapi/proxy/plugin_resource_tracker.h"
 #include "ppapi/proxy/plugin_var_serialization_rules.h"
 #include "ppapi/proxy/ppapi_messages.h"
 #include "ppapi/proxy/ppb_char_set_proxy.h"
 #include "ppapi/proxy/ppb_cursor_control_proxy.h"
 #include "ppapi/proxy/ppb_font_proxy.h"
 #include "ppapi/proxy/ppb_instance_proxy.h"
 #include "ppapi/proxy/ppp_class_proxy.h"
@@ skipping 20 matching lines @@
   memset(&position, 0, sizeof(position));
 }
 
 PluginDispatcher::PluginDispatcher(base::ProcessHandle remote_process_handle,
                                    GetInterfaceFunc get_interface)
     : Dispatcher(remote_process_handle, get_interface),
       plugin_delegate_(NULL),
       received_preferences_(false),
       plugin_dispatcher_id_(0) {
   SetSerializationRules(new PluginVarSerializationRules);
-
-  // As a plugin, we always support the PPP_Class interface. There's no
-  // GetInterface call or name for it, so we insert it into our table now.
-  target_proxies_[INTERFACE_ID_PPP_CLASS].reset(new PPP_Class_Proxy(this));
-
   TrackerBase::Init(&PluginResourceTracker::GetTrackerBaseInstance);
 }
 
 PluginDispatcher::~PluginDispatcher() {
   if (plugin_delegate_)
     plugin_delegate_->Unregister(plugin_dispatcher_id_);
 }
 
 // static
 PluginDispatcher* PluginDispatcher::GetForInstance(PP_Instance instance) {
   if (!g_instance_to_dispatcher)
     return NULL;
   InstanceToDispatcherMap::iterator found = g_instance_to_dispatcher->find(
       instance);
   if (found == g_instance_to_dispatcher->end())
     return NULL;
   return found->second;
 }
 
 // static
 PluginDispatcher* PluginDispatcher::GetForResource(const Resource* resource) {
   return GetForInstance(resource->pp_instance());
 }
 
 // static
-const void* PluginDispatcher::GetInterfaceFromDispatcher(
-    const char* dispatcher_interface) {
-  // All interfaces the plugin requests of the browser are "PPB".
-  const InterfaceProxy::Info* info = GetPPBInterfaceInfo(dispatcher_interface);
-  if (!info)
-    return NULL;
-  return info->interface_ptr;
+const void* PluginDispatcher::GetBrowserInterface(const char* interface_name) {
+  return InterfaceList::GetInstance()->GetInterfaceForPPB(interface_name);
+}
+
+const void* PluginDispatcher::GetPluginInterface(
+    const std::string& interface_name) {
+  InterfaceMap::iterator found = plugin_interfaces_.find(interface_name);
+  if (found == plugin_interfaces_.end()) {
+    const void* ret = local_get_interface()(interface_name.c_str());
+    plugin_interfaces_.insert(std::make_pair(interface_name, ret));
+    return ret;
+  }
+  return found->second;
 }
 
 bool PluginDispatcher::InitPluginWithChannel(
     PluginDelegate* delegate,
     const IPC::ChannelHandle& channel_handle,
     bool is_client) {
   if (!Dispatcher::InitWithChannel(delegate, channel_handle, is_client))
     return false;
   plugin_delegate_ = delegate;
   plugin_dispatcher_id_ = plugin_delegate_->Register(this);
@@ skipping 21 matching lines @@
   // Allowing all async messages to unblock the renderer means more reentrancy
   // there but gives correct ordering.
   msg->set_unblock(true);
   return Dispatcher::Send(msg);
 }
 
 bool PluginDispatcher::OnMessageReceived(const IPC::Message& msg) {
   TRACE_EVENT2("ppapi proxy", "PluginDispatcher::OnMessageReceived",
                "Class", IPC_MESSAGE_ID_CLASS(msg.type()),
                "Line", IPC_MESSAGE_ID_LINE(msg.type()));
-  // Handle common control messages.
-  if (Dispatcher::OnMessageReceived(msg))
-    return true;
-
   if (msg.routing_id() == MSG_ROUTING_CONTROL) {
     // Handle some plugin-specific control messages.
     bool handled = true;
     IPC_BEGIN_MESSAGE_MAP(PluginDispatcher, msg)
       IPC_MESSAGE_HANDLER(PpapiMsg_SupportsInterface, OnMsgSupportsInterface)
       IPC_MESSAGE_HANDLER(PpapiMsg_SetPreferences, OnMsgSetPreferences)
+      IPC_MESSAGE_UNHANDLED(handled = false);
     IPC_END_MESSAGE_MAP()
-    return handled;
+    if (handled)
+      return true;
   }
-
-  if (msg.routing_id() <= 0 || msg.routing_id() >= INTERFACE_ID_COUNT) {
-    // Host is sending us garbage. Since it's supposed to be trusted, this
-    // isn't supposed to happen. Crash here in all builds in case the renderer
-    // is compromised.
-    CHECK(false);
-    return true;
-  }
-
-  // There are two cases:
-  //
-  // * The first case is that the host is calling a PPP interface. It will
-  //   always do a check for the interface before sending messages, and this
-  //   will create the necessary interface proxy at that time. So when we
-  //   actually receive a message, we know such a proxy will exist.
-  //
-  // * The second case is that the host is sending a response to the plugin
-  //   side of a PPB interface (some, like the URL loader, have complex
-  //   response messages). Since the host is trusted and not supposed to be
-  //   doing silly things, we can just create a PPB proxy project on demand the
-  //   first time it's needed.
-
-  InterfaceProxy* proxy = target_proxies_[msg.routing_id()].get();
-  if (!proxy) {
-    // Handle the first time the host calls a PPB reply interface by
-    // autocreating it.
-    const InterfaceProxy::Info* info = GetPPBInterfaceInfo(
-        static_cast<InterfaceID>(msg.routing_id()));
-    if (!info) {
-      NOTREACHED();
-      return true;
-    }
-    proxy = info->create_proxy(this, NULL);
-    target_proxies_[info->id].reset(proxy);
-  }
-
-  return proxy->OnMessageReceived(msg);
+  return Dispatcher::OnMessageReceived(msg);
 }
 
 void PluginDispatcher::OnChannelError() {
   Dispatcher::OnChannelError();
 
   // The renderer has crashed or exited. This channel and all instances
   // associated with it are no longer valid.
   ForceFreeAllInstances();
   // TODO(brettw) free resources too!
   delete this;
@@ skipping 37 matching lines @@
 
 bool PluginDispatcher::SendToBrowser(IPC::Message* msg) {
   return plugin_delegate_->SendToBrowser(msg);
 }
 
 WebKitForwarding* PluginDispatcher::GetWebKitForwarding() {
   return plugin_delegate_->GetWebKitForwarding();
 }
 
 FunctionGroupBase* PluginDispatcher::GetFunctionAPI(InterfaceID id) {
-  scoped_ptr<FunctionGroupBase >& proxy = function_proxies_[id];
-
-  if (proxy.get())
-    return proxy.get();
-
-  if (id == INTERFACE_ID_PPB_CHAR_SET)
-    proxy.reset(new PPB_CharSet_Proxy(this, NULL));
-  else if(id == INTERFACE_ID_PPB_CURSORCONTROL)
-    proxy.reset(new PPB_CursorControl_Proxy(this, NULL));
-  else if (id == INTERFACE_ID_PPB_FONT)
-    proxy.reset(new PPB_Font_Proxy(this, NULL));
-  else if (id == INTERFACE_ID_PPB_INSTANCE)
-    proxy.reset(new PPB_Instance_Proxy(this, NULL));
-  else if (id == INTERFACE_ID_RESOURCE_CREATION)
-    proxy.reset(new ResourceCreationProxy(this));
-
-  return proxy.get();
+  return GetInterfaceProxy(id);
 }
 
 void PluginDispatcher::ForceFreeAllInstances() {
   if (!g_instance_to_dispatcher)
     return;
 
   // Iterating will remove each item from the map, so we need to make a copy
   // to avoid things changing out from under is.
   InstanceToDispatcherMap temp_map = *g_instance_to_dispatcher;
   for (InstanceToDispatcherMap::iterator i = temp_map.begin();
        i != temp_map.end(); ++i) {
     if (i->second == this) {
       // Synthesize an "instance destroyed" message, this will notify the
       // plugin and also remove it from our list of tracked plugins.
       PpapiMsg_PPPInstance_DidDestroy msg(INTERFACE_ID_PPP_INSTANCE, i->first);
       OnMessageReceived(msg);
     }
   }
 }
 
 void PluginDispatcher::OnMsgSupportsInterface(
     const std::string& interface_name,
     bool* result) {
-  *result = false;
-
-  // Setup a proxy for receiving the messages from this interface.
-  const InterfaceProxy::Info* info = GetPPPInterfaceInfo(interface_name);
-  if (!info)
-    return;  // Interface not supported by proxy.
-
-  // Check for a cached result.
-  if (target_proxies_[info->id].get()) {
-    *result = true;
-    return;
-  }
-
-  // Query the plugin & cache the result.
-  const void* interface_functions = GetLocalInterface(interface_name.c_str());
-  if (!interface_functions)
-    return;
-  target_proxies_[info->id].reset(
-      info->create_proxy(this, interface_functions));
-  *result = true;
+  *result = !!GetPluginInterface(interface_name);
 }
 
 void PluginDispatcher::OnMsgSetPreferences(const Preferences& prefs) {
   // The renderer may send us preferences more than once (currently this
   // happens every time a new plugin instance is created). Since we don't have
   // a way to signal to the plugin that the preferences have changed, changing
   // the default fonts and such in the middle of a running plugin could be
   // confusing to it. As a result, we never allow the preferences to be changed
   // once they're set. The user will have to restart to get new font prefs
   // propogated to plugins.
   if (!received_preferences_) {
     received_preferences_ = true;
     preferences_ = prefs;
   }
 }
 
 }  // namespace proxy
 }  // namespace ppapi