src/execution.cc - Issue 7886032: Fixed spurious character in test case, plus presubmit issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/execution.cc

Issue 7886032: Fixed spurious character in test case, plus presubmit issues. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/execution.cc

diff --git a/src/execution.cc b/src/execution.cc

index 7ad2dc0be8d5c62b153adf04fdf455a2091db890..7d5f889014a66d8953466c0fe50ae9cc6ca93a02 100644

--- a/src/execution.cc

+++ b/src/execution.cc

@@ -162,7 +162,7 @@ Handle<Object> Execution::Call(Handle<Object> callable,

!func->shared()->native() && !func->shared()->strict_mode()) {

if (receiver->IsUndefined() || receiver->IsNull()) {

Object* global = func->context()->global()->global_receiver();

- // For reasons that escape me, 'global' can be the JSBuiltinsObject

+ // For somehwat unclear reasons, 'global' can be the JSBuiltinsObject

Jakob Kummerow 2011/09/14 07:23:26 nit: s/hwat/what/ Or just remove the "For...reason

rossberg 2011/09/14 07:30:58 Done.

// under some circumstances. In that case, don't rewrite.

// FWIW, the same holds for GetIsolate()->global()->global_receiver().

if (!global->IsJSBuiltinsObject()) receiver = Handle<Object>(global);

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-bind-receiver.js » ('j') | test/mjsunit/regress/regress-bind-receiver.js » ('J')