Issue 7886032: Fixed spurious character in test case, plus presubmit issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7886032: Fixed spurious character in test case, plus presubmit issues. (Closed)

Created:
9 years, 3 months ago by rossberg

Modified:
9 years, 3 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fixed spurious character in test case, plus presubmit issues. Also addressed Slava's complaint about the personalized comment. R=jkummerow@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9268

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed Jakob's comments. #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -5 lines)			Patch
	M	src/execution.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
	M	test/mjsunit/regress/regress-bind-receiver.js	View	1	1 chunk	+29 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with nits. http://codereview.chromium.org/7886032/diff/1/src/execution.cc File src/execution.cc (right): http://codereview.chromium.org/7886032/diff/1/src/execution.cc#newcode165 src/execution.cc:165: // For somehwat unclear reasons, 'global' ...

9 years, 3 months ago (2011-09-14 07:23:26 UTC) #2

rossberg

9 years, 3 months ago (2011-09-14 07:30:58 UTC) #3

http://codereview.chromium.org/7886032/diff/1/src/execution.cc
File src/execution.cc (right):

http://codereview.chromium.org/7886032/diff/1/src/execution.cc#newcode165
src/execution.cc:165: // For somehwat unclear reasons, 'global' can be the
JSBuiltinsObject
On 2011/09/14 07:23:26, Jakob wrote:
> nit: s/hwat/what/
> Or just remove the "For...reasons" part completely.

Done.

http://codereview.chromium.org/7886032/diff/1/test/mjsunit/regress/regress-bi...
File test/mjsunit/regress/regress-bind-receiver.js (right):

http://codereview.chromium.org/7886032/diff/1/test/mjsunit/regress/regress-bi...
test/mjsunit/regress/regress-bind-receiver.js:28: // Check that modifying an
array while sorting it does not segfault. See
On 2011/09/14 07:23:26, Jakob wrote:
> I think this comment does not apply to this test.

Oops. :)

Expand Messages | Collapse Messages