Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 7886032: Fixed spurious character in test case, plus presubmit issues. (Closed)

Created:
9 years, 3 months ago by rossberg
Modified:
9 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fixed spurious character in test case, plus presubmit issues. Also addressed Slava's complaint about the personalized comment. R=jkummerow@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9268

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed Jakob's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -5 lines) Patch
M src/execution.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/regress/regress-bind-receiver.js View 1 1 chunk +29 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
9 years, 3 months ago (2011-09-14 06:06:51 UTC) #1
Jakob Kummerow
LGTM with nits. http://codereview.chromium.org/7886032/diff/1/src/execution.cc File src/execution.cc (right): http://codereview.chromium.org/7886032/diff/1/src/execution.cc#newcode165 src/execution.cc:165: // For somehwat unclear reasons, 'global' ...
9 years, 3 months ago (2011-09-14 07:23:26 UTC) #2
rossberg
9 years, 3 months ago (2011-09-14 07:30:58 UTC) #3
http://codereview.chromium.org/7886032/diff/1/src/execution.cc
File src/execution.cc (right):

http://codereview.chromium.org/7886032/diff/1/src/execution.cc#newcode165
src/execution.cc:165: // For somehwat unclear reasons, 'global' can be the
JSBuiltinsObject
On 2011/09/14 07:23:26, Jakob wrote:
> nit: s/hwat/what/
> Or just remove the "For...reasons" part completely.

Done.

http://codereview.chromium.org/7886032/diff/1/test/mjsunit/regress/regress-bi...
File test/mjsunit/regress/regress-bind-receiver.js (right):

http://codereview.chromium.org/7886032/diff/1/test/mjsunit/regress/regress-bi...
test/mjsunit/regress/regress-bind-receiver.js:28: // Check that modifying an
array while sorting it does not segfault. See
On 2011/09/14 07:23:26, Jakob wrote:
> I think this comment does not apply to this test.

Oops. :)

Powered by Google App Engine
This is Rietveld 408576698