Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 7886002: Revert "Clean up Context::Lookup and its uses." (Closed)

Created:
9 years, 3 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 3 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Revert "Clean up Context::Lookup and its uses." This reverts commit 9241. This change shows failures on Mac and Win for the threading tests. Reverting while I investigate. R=fschneider@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9246

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -182 lines) Patch
M src/contexts.h View 2 chunks +24 lines, -14 lines 0 comments Download
M src/contexts.cc View 3 chunks +54 lines, -46 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 14 chunks +167 lines, -122 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 3 months ago (2011-09-13 07:41:49 UTC) #1
fschneider
9 years, 3 months ago (2011-09-13 08:34:37 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698