Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: content/common/webkit_param_traits.cc

Issue 7885043: Improve IPC logging for ChannelHandle and NPVariant_Param (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed minor typo Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ipc/ipc_message_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/webkit_param_traits.cc
diff --git a/content/common/webkit_param_traits.cc b/content/common/webkit_param_traits.cc
index 37e4b362c2d1c431263daa368c2b9cdf88c48ea3..634e4076305f38765b8c25c7902a0ff068b6b2a0 100644
--- a/content/common/webkit_param_traits.cc
+++ b/content/common/webkit_param_traits.cc
@@ -302,6 +302,7 @@ bool ParamTraits<NPVariant_Param>::Read(const Message* m,
}
void ParamTraits<NPVariant_Param>::Log(const param_type& p, std::string* l) {
+ l->append(StringPrintf("NPVariant_Param(%d, ", static_cast<int>(p.type)));
if (p.type == NPVARIANT_PARAM_BOOL) {
LogParam(p.bool_value, l);
} else if (p.type == NPVARIANT_PARAM_INT) {
@@ -313,7 +314,10 @@ void ParamTraits<NPVariant_Param>::Log(const param_type& p, std::string* l) {
} else if (p.type == NPVARIANT_PARAM_SENDER_OBJECT_ROUTING_ID ||
p.type == NPVARIANT_PARAM_RECEIVER_OBJECT_ROUTING_ID) {
LogParam(p.npobject_routing_id, l);
+ } else {
+ l->append("<none>");
}
+ l->append(")");
}
void ParamTraits<NPIdentifier_Param>::Write(Message* m, const param_type& p) {
« no previous file with comments | « no previous file | ipc/ipc_message_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698