Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: gclient_utils.py

Issue 7885032: Add diagnostics in can an item is run multiple times (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient_utils.py
diff --git a/gclient_utils.py b/gclient_utils.py
index d668c5372345a0196ea1cfcb9cc117519383c110..9be529cc01ee08cdee8eb690ad34c45dffc6106f 100644
--- a/gclient_utils.py
+++ b/gclient_utils.py
@@ -332,7 +332,6 @@ def CheckCallAndFilter(args, stdout=None, filter_fn=None,
assert print_stdout or filter_fn
stdout = stdout or sys.stdout
filter_fn = filter_fn or (lambda x: None)
- assert not 'stderr' in kwargs
kid = subprocess2.Popen(
args, bufsize=0, stdout=subprocess2.PIPE, stderr=subprocess2.STDOUT,
**kwargs)
@@ -588,7 +587,10 @@ class ExecutionQueue(object):
sys.stdout.full_flush() # pylint: disable=E1101
if self.progress:
self.progress.update(1, t.item.name)
- assert not t.item.name in self.ran
+ if t.item.name in self.ran:
+ raise Error(
+ 'gclient is confused, "%s" is already in "%s"' % (
+ t.item.name, ', '.join(self.ran)))
if not t.item.name in self.ran:
self.ran.append(t.item.name)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698