Issue 7885031: Redirect chrome://extensions to the new chrome://settings/chromeExtensions (attempt 2).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7885031: Redirect chrome://extensions to the new chrome://settings/chromeExtensions (attempt 2). (Closed)

Created:
9 years, 3 months ago by Finnur

Modified:
9 years, 3 months ago

Reviewers:
joi, Jói

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Redirect chrome://extensions to the new chrome://settings/chromeExtensions (attempt 2). The two modifications to the tests were needed because they were trying to open chrome://extensions in incognito. In one case, the test just needed any page (so I switched to about:blank) and in the other we are testing for a condition that cannot happen anymore because chrome://extensions could be loaded in incognito but chrome://settings doesn't allow that -- it shunts the request to the non-incognito profile. The test was testing that we don't crash in incognito, so I removed that test. BUG=87377 TEST=Well... type in chrome://extensions and notice it redirects. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101081

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -20 lines)			Patch
M	chrome/browser/browser_about_handler.cc	View	1 chunk	+12 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/browser_action_apitest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_management_browsertest.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/notifications/has_permission_manifest/background.html	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Finnur

This is the same changelist as... http://codereview.chromium.org/7888010/ ... except I updated the string in the ...

9 years, 3 months ago (2011-09-14 15:38:11 UTC) #1

LGTM

Expand Messages | Collapse Messages