Fixing d8's broken readline history.

src/d8-readline.cc

 // Copyright 2008 the V8 project authors. All rights reserved.

[Jakob Kummerow, 2011/09/14 14:18:42]

2011

 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
 //       with the distribution.
@@ skipping 53 matching lines @@
     '\\', '\'', '`', '@', '.', '>', '<', '=', ';', '|', '&', '{', '(',
     '\0'};
 
 
 bool ReadLineEditor::Open() {
   rl_initialize();
   rl_attempted_completion_function = AttemptedCompletion;
   rl_completer_word_break_characters = kWordBreakCharacters;
   rl_bind_key('\t', rl_complete);
   using_history();
+  stifle_history(Shell::kMaxHistoryEntries);
   return read_history(Shell::kHistoryFileName) == 0;
 }
 
 
 bool ReadLineEditor::Close() {
   return write_history(Shell::kHistoryFileName) == 0;
 }
 
 
 i::SmartArrayPointer<char> ReadLineEditor::Prompt(const char* prompt) {
   char* result = readline(prompt);
   return i::SmartArrayPointer<char>(result);
 }
 
 
 void ReadLineEditor::AddHistory(const char* str) {
+  // Do not record empty input.
+  if (strlen(str) == 0) return;
+  // Remove duplicate history entry.
+  history_set_pos(0);
+  if (current_history()) {
+    do {
+      if (strcmp(current_history()->line, str) == 0) {
+        remove_history(where_history());
+        break;
+      }
+    } while (next_history());
+  }
   add_history(str);
 }
 
 
 char** ReadLineEditor::AttemptedCompletion(const char* text,
                                            int start,
                                            int end) {
   char** result = completion_matches(text, CompletionGenerator);
   rl_attempted_completion_over = true;
   return result;
@@ skipping 20 matching lines @@
     return strdup(*str);
   } else {
     current_completions.Dispose();
     current_completions.Clear();
     return NULL;
   }
 }
 
 
 }  // namespace v8