Issue 7885026: Fixing d8's broken readline history.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7885026: Fixing d8's broken readline history. (Closed)

Created:
9 years, 3 months ago by Yang

Modified:
9 years, 3 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fixing d8's broken readline history. Committed: http://code.google.com/p/v8/source/detail?r=9282

Patch Set 1 #

Patch Set 2 : Fixed a presubmit issue. #

Total comments: 1

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -29 lines)			Patch
M	src/d8.h	View		3 chunks	+25 lines, -23 lines	0 comments	Download
M	src/d8.cc	View		4 chunks	+8 lines, -6 lines	0 comments	Download
M	src/d8-readline.cc	View	1	2 chunks	+13 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

Here's the second attempt. It turned out to be a NULL pointer access. Additionally, I ...

9 years, 3 months ago (2011-09-14 14:01:18 UTC) #1

Jakob Kummerow

9 years, 3 months ago (2011-09-14 14:18:42 UTC) #2

OK, let's try this again. LGTM.

http://codereview.chromium.org/7885026/diff/5/src/d8-readline.cc
File src/d8-readline.cc (right):

http://codereview.chromium.org/7885026/diff/5/src/d8-readline.cc#newcode1
src/d8-readline.cc:1: // Copyright 2008 the V8 project authors. All rights
reserved.
2011

Expand Messages | Collapse Messages