Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 7885009: Removed the dependency of PepperPluginRegistry on Pepper proxy. (Closed)

Created:
9 years, 3 months ago by alokp
Modified:
9 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke+watch-content_chromium.org, jam
Visibility:
Public.

Description

Removed the dependency of PepperPluginRegistry on Pepper proxy. We would need to move PepperPluginRegistry to webkit/plugins/ppapi so that it can be used by test_shell. But before we can move it, we need to remove all dependencies on content and pepper/proxy. TEST=Manually ran pepper 3d demos in-process and out-of-process.

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -50 lines) Patch
M content/common/pepper_plugin_registry.h View 1 2 3 3 chunks +1 line, -7 lines 0 comments Download
M content/common/pepper_plugin_registry.cc View 1 2 3 2 chunks +0 lines, -11 lines 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.cc View 1 2 3 5 chunks +45 lines, -31 lines 0 comments Download
M ppapi/proxy/proxy_channel.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
alokp
9 years, 3 months ago (2011-09-13 19:14:24 UTC) #1
brettw
I think this will work. The key thing is that a dispatcher outlives instances. As ...
9 years, 3 months ago (2011-09-14 17:05:37 UTC) #2
alokp
On 2011/09/14 17:05:37, brettw wrote: > I think this will work. > > The key ...
9 years, 3 months ago (2011-09-14 17:13:19 UTC) #3
alokp
Also tested with multiple instances of a plugin. Manually deleted plugin instances via dev-tools console. ...
9 years, 3 months ago (2011-09-14 17:42:04 UTC) #4
brettw
LGTM
9 years, 3 months ago (2011-09-14 20:17:45 UTC) #5
commit-bot: I haz the power
9 years, 3 months ago (2011-09-15 07:36:51 UTC) #6
Change committed as 101259

Powered by Google App Engine
This is Rietveld 408576698