Moving ContentSettingsPattern from chrome/browser/content_settings to chrome/common.

Moving ContentSettingsPattern and ContentSettingsPatternParser from chrome/browser/content_settings to chrome/common.

This is needed for transmitting image-related content settings to the renderer.

BUG=81179
TEST=NONE

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102088

[marja, 2011-09-13 11:03:57]

Hi,

This changelist moves
chrome/browser/content_settings/content_settings_pattern(.h|.cc|unittests.cc) to
chrome/common/. This is needed since we'd like to transfer the image content
settings to the renderer to enable more complicated image-related content
settings than just block/allow.

Could you review the following parts:
markusheintz: everything
johnnyg: chrome/browser/notifications/*
stuartmorgan: chrome/browser/ui/webui/options/content_settings_handler.cc

Thanks!

[stuartmorgan, 2011-09-13 11:14:46]

WebUI change LGTM, but if you aren't going to have a bug link in the CL it would
be nice to have more description of why this is being done. (Is there really no
bug for what sounds like a new user-facing feature? I know this wouldn't fix
such a bug, but if it supports an existing bug that should be in the BUG= line)

[markusheintz_, 2011-09-13 11:19:55]

LGTM

[marja, 2011-09-13 12:21:38]

I had to move ContentSettingsPatternParser too, since ContentSettingsPattern
depends on it. markusheinz, still LGTY?

stuartmorgan: Thanks for the comment, I added reference to bug 81179.

[markusheintz_, 2011-09-13 12:42:38]

Still LGTM. Thanks for moving that code to common

[John Gregg, 2011-09-15 16:48:10]

LGTM

[commit-bot: I haz the power, 2011-09-16 06:55:32]

Can't apply patch for file chrome/common/content_settings_pattern.h.
While running patch -p1 --forward --force;
patching file chrome/common/content_settings_pattern.h
Hunk #1 FAILED at 4.
Hunk #2 FAILED at 254.
2 out of 2 hunks FAILED -- saving rejects to file
chrome/common/content_settings_pattern.h.rej

[commit-bot: I haz the power, 2011-09-21 05:32:45]

Can't apply patch for file chrome/common/content_settings_pattern.h.
While running patch -p1 --forward --force;
patching file chrome/common/content_settings_pattern.h
Hunk #1 FAILED at 4.
Hunk #2 FAILED at 254.
2 out of 2 hunks FAILED -- saving rejects to file
chrome/common/content_settings_pattern.h.rej