Issue 7878003: Enable multi-profiles on M16

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7878003: Enable multi-profiles on M16 (Closed)

Created:
9 years, 3 months ago by sail

Modified:
9 years, 3 months ago

Reviewers:
Robert Sesek, Elliot Glaysher

CC:
chromium-reviews, rginda+watch_chromium.org, achuith+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Enable multi-profiles on M16 This change enables multi-profiles by default on Windows and Mac and puts it behind a flag for Linux. BUG= TEST=

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	chrome/browser/about_flags.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/profiles/profile_manager.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

I actually have this out as http://codereview.chromium.org/7861025/ but it's blocked on http://codereview.chromium.org/7780031/.

9 years, 3 months ago (2011-09-12 21:43:01 UTC) #2

sail

On 2011/09/12 21:43:01, rsesek wrote: > I actually have this out as http://codereview.chromium.org/7861025/ but it's ...

9 years, 3 months ago (2011-09-12 21:45:16 UTC) #3

Robert Sesek

On 2011/09/12 21:45:16, sail wrote: > On 2011/09/12 21:43:01, rsesek wrote: > > I actually ...

9 years, 3 months ago (2011-09-12 21:46:07 UTC) #4

sail

9 years, 3 months ago (2011-09-12 21:47:46 UTC) #5

On 2011/09/12 21:46:07, rsesek wrote:
> On 2011/09/12 21:45:16, sail wrote:
> > On 2011/09/12 21:43:01, rsesek wrote:
> > > I actually have this out as http://codereview.chromium.org/7861025/ but
it's
> > > blocked on http://codereview.chromium.org/7780031/.
> > 
> > Is it worth doing just the windows bit for now?
> 
> Probably not. Miranda will land that CL tomorrow.

Sounds good. Closing this CL.

Expand Messages | Collapse Messages