Issue 7878002: Fixed GAIA session cookie fetching.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7878002: Fixed GAIA session cookie fetching. (Closed)

Created:
9 years, 3 months ago by zel

Modified:
9 years, 3 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, davemoore+watch_chromium.org, stevenjb, nkostylev+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fixed GAIA session cookie fetching. BUG=chromium-os:20103 TEST=sign out of GAIA while logged in, sign out of ChromeOS and sing in again. GAIA session should be autheticated. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100797

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -11 lines)			Patch
	M	chrome/browser/chromeos/login/login_utils.cc	View	1 2 3	4 chunks	+74 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

xiyuan

LGTM with nits http://codereview.chromium.org/7878002/diff/3001/chrome/browser/chromeos/login/login_utils.cc File chrome/browser/chromeos/login/login_utils.cc (right): http://codereview.chromium.org/7878002/diff/3001/chrome/browser/chromeos/login/login_utils.cc#newcode112 chrome/browser/chromeos/login/login_utils.cc:112: Profile* user_profile_; nit: this seems no ...

9 years, 3 months ago (2011-09-12 22:21:05 UTC) #2

zel

9 years, 3 months ago (2011-09-12 23:11:10 UTC) #3

http://codereview.chromium.org/7878002/diff/3001/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/login_utils.cc (right):

http://codereview.chromium.org/7878002/diff/3001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/login_utils.cc:112: Profile* user_profile_;
On 2011/09/12 22:21:05, xiyuan wrote:
> nit: this seems no longer in use.

Done.

http://codereview.chromium.org/7878002/diff/3001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/login_utils.cc:278: Profile* user_profile_;
On 2011/09/12 22:21:05, xiyuan wrote:
> nit: seems no need to keep this as member variable.

Done.

Expand Messages | Collapse Messages