Issue 7875004: Fix gcl sometimes stripping the new line characters when changing the issue description on the se...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7875004: Fix gcl sometimes stripping the new line characters when changing the issue description on the se... (Closed)

Created:
9 years, 3 months ago by jam

Modified:
9 years, 3 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
http://src.chromium.org/svn/trunk/tools/depot_tools/

Visibility:
Public.

Description

Fix gcl sometimes stripping the new line characters when changing the issue description on the server. This change replaces \n with \r\n before giving the description to the editor on Windows (not through cygwin though), and then replaces \r\n with \n when saving it locally or sending it to reitveld. BUG=95618 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101863

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	gcl.py	View		3 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

lgtm, although I'm not sure why you deleted that one blank line ...

9 years, 3 months ago (2011-09-12 23:57:58 UTC) #2

jam

9 years, 3 months ago (2011-09-13 00:26:30 UTC) #3

On 2011/09/12 23:57:58, Dirk Pranke wrote:
> lgtm, although I'm not sure why you deleted that one blank line ...

no reason, I had added a bunch of logging and removed it after, and I removed
this blank line with it. added it back.

Expand Messages | Collapse Messages