Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: ppapi/proxy/ppp_instance_private_proxy.h

Issue 7874002: This patch tries to remove most of the manual registration for Pepper interfaces, and replaces it... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/ppp_input_event_proxy.cc ('k') | ppapi/proxy/ppp_instance_private_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/ppp_instance_private_proxy.h
===================================================================
--- ppapi/proxy/ppp_instance_private_proxy.h (revision 100758)
+++ ppapi/proxy/ppp_instance_private_proxy.h (working copy)
@@ -20,16 +20,11 @@
class PPP_Instance_Private_Proxy : public InterfaceProxy {
public:
- PPP_Instance_Private_Proxy(Dispatcher* dispatcher,
- const void* target_interface);
+ PPP_Instance_Private_Proxy(Dispatcher* dispatcher);
virtual ~PPP_Instance_Private_Proxy();
static const Info* GetInfo();
- const PPP_Instance_Private* ppp_instance_private_target() const {
- return reinterpret_cast<const PPP_Instance_Private*>(target_interface());
- }
-
private:
// InterfaceProxy implementation.
virtual bool OnMessageReceived(const IPC::Message& msg);
@@ -37,6 +32,13 @@
// Message handlers.
void OnMsgGetInstanceObject(PP_Instance instance,
SerializedVarReturnValue result);
+
+ // When this proxy is in the plugin side, this value caches the interface
+ // pointer so we don't have to retrieve it from the dispatcher each time.
+ // In the host, this value is always NULL.
+ const PPP_Instance_Private* ppp_instance_private_impl_;
+
+ DISALLOW_COPY_AND_ASSIGN(PPP_Instance_Private_Proxy);
};
} // namespace proxy
« no previous file with comments | « ppapi/proxy/ppp_input_event_proxy.cc ('k') | ppapi/proxy/ppp_instance_private_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698