Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: ppapi/proxy/ppb_video_capture_proxy.h

Issue 7874002: This patch tries to remove most of the manual registration for Pepper interfaces, and replaces it... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/ppb_var_unittest.cc ('k') | ppapi/proxy/ppb_video_capture_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/ppb_video_capture_proxy.h
===================================================================
--- ppapi/proxy/ppb_video_capture_proxy.h (revision 100758)
+++ ppapi/proxy/ppb_video_capture_proxy.h (working copy)
@@ -21,20 +21,16 @@
class PPB_VideoCapture_Proxy : public InterfaceProxy {
public:
- PPB_VideoCapture_Proxy(Dispatcher* dispatcher, const void* target_interface);
+ PPB_VideoCapture_Proxy(Dispatcher* dispatcher);
virtual ~PPB_VideoCapture_Proxy();
- static const Info* GetInfo();
-
static PP_Resource CreateProxyResource(PP_Instance instance);
- const PPB_VideoCapture_Dev* ppb_video_capture_target() const {
- return static_cast<const PPB_VideoCapture_Dev*>(target_interface());
- }
-
// InterfaceProxy implementation.
virtual bool OnMessageReceived(const IPC::Message& msg);
+ static const InterfaceID kInterfaceID = INTERFACE_ID_PPB_VIDEO_CAPTURE_DEV;
+
private:
// Message handlers.
void OnMsgCreate(PP_Instance instance, ppapi::HostResource* result_resource);
@@ -44,22 +40,22 @@
void OnMsgReuseBuffer(const ppapi::HostResource& resource,
uint32_t buffer);
void OnMsgStopCapture(const ppapi::HostResource& resource);
+
+ DISALLOW_COPY_AND_ASSIGN(PPB_VideoCapture_Proxy);
};
class PPP_VideoCapture_Proxy : public InterfaceProxy {
public:
- PPP_VideoCapture_Proxy(Dispatcher* dispatcher, const void* target_interface);
+ PPP_VideoCapture_Proxy(Dispatcher* dispatcher);
virtual ~PPP_VideoCapture_Proxy();
static const Info* GetInfo();
- const PPP_VideoCapture_Dev* ppp_video_capture_target() const {
- return static_cast<const PPP_VideoCapture_Dev*>(target_interface());
- }
-
// InterfaceProxy implementation.
virtual bool OnMessageReceived(const IPC::Message& msg);
+ static const InterfaceID kInterfaceID = INTERFACE_ID_PPP_VIDEO_CAPTURE_DEV;
+
private:
// Message handlers.
void OnMsgOnDeviceInfo(const ppapi::HostResource& video_capture,
@@ -71,6 +67,13 @@
uint32_t error_code);
void OnMsgOnBufferReady(const ppapi::HostResource& video_capture,
uint32_t buffer);
+
+ // When this proxy is in the plugin side, this value caches the interface
+ // pointer so we don't have to retrieve it from the dispatcher each time.
+ // In the host, this value is always NULL.
+ const PPP_VideoCapture_Dev* ppp_video_capture_impl_;
+
+ DISALLOW_COPY_AND_ASSIGN(PPP_VideoCapture_Proxy);
};
} // namespace proxy
« no previous file with comments | « ppapi/proxy/ppb_var_unittest.cc ('k') | ppapi/proxy/ppb_video_capture_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698