This patch tries to remove most of the manual registration for Pepper interfaces, and replaces it...

ppapi/proxy/ppb_video_decoder_proxy.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/proxy/ppb_video_decoder_proxy.h"
 
 #include "base/logging.h"
 #include "gpu/command_buffer/client/gles2_implementation.h"
 #include "ppapi/proxy/enter_proxy.h"
 #include "ppapi/proxy/plugin_dispatcher.h"
@@ skipping 136 matching lines @@
 
 void VideoDecoder::FlushACK(int32_t result) {
   RunFlushCallback(result);
 }
 
 void VideoDecoder::EndOfBitstreamACK(
     int32_t bitstream_buffer_id, int32_t result) {
   RunBitstreamBufferCallback(bitstream_buffer_id, result);
 }
 
-namespace {
-
-InterfaceProxy* CreateVideoDecoderProxy(Dispatcher* dispatcher,
-                                        const void* target_interface) {
-  return new PPB_VideoDecoder_Proxy(dispatcher, target_interface);
-}
-
-}  // namespace
-
-PPB_VideoDecoder_Proxy::PPB_VideoDecoder_Proxy(Dispatcher* dispatcher,
-                                               const void* target_interface)
-    : InterfaceProxy(dispatcher, target_interface),
+PPB_VideoDecoder_Proxy::PPB_VideoDecoder_Proxy(Dispatcher* dispatcher)
+    : InterfaceProxy(dispatcher),
       callback_factory_(ALLOW_THIS_IN_INITIALIZER_LIST(this)) {
 }
 
 PPB_VideoDecoder_Proxy::~PPB_VideoDecoder_Proxy() {
 }
 
-// static
-const InterfaceProxy::Info* PPB_VideoDecoder_Proxy::GetInfo() {
-  static const Info info = {
-    thunk::GetPPB_VideoDecoder_Thunk(),
-    PPB_VIDEODECODER_DEV_INTERFACE,
-    INTERFACE_ID_PPB_VIDEO_DECODER_DEV,
-    false,
-    &CreateVideoDecoderProxy,
-  };
-  return &info;
-}
-
 bool PPB_VideoDecoder_Proxy::OnMessageReceived(const IPC::Message& msg) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(PPB_VideoDecoder_Proxy, msg)
     IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBVideoDecoder_Create,
                         OnMsgCreate)
     IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBVideoDecoder_Decode, OnMsgDecode)
     IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBVideoDecoder_AssignPictureBuffers,
                         OnMsgAssignPictureBuffers)
     IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBVideoDecoder_ReusePictureBuffer,
                         OnMsgReusePictureBuffer)
@@ skipping 48 matching lines @@
   // Need a scoped_refptr to keep the object alive during the Init call.
   scoped_refptr<VideoDecoder> decoder(new VideoDecoder(result));
   decoder->InitCommon(graphics_context, gles2_impl);
   return decoder->GetReference();
 }
 
 void PPB_VideoDecoder_Proxy::OnMsgCreate(
     PP_Instance instance, const HostResource& graphics_context,
     PP_VideoDecoder_Profile profile,
     HostResource* result) {
-  thunk::EnterFunction<thunk::ResourceCreationAPI> resource_creation(instance,
-                                                                     true);
+  thunk::EnterResourceCreation resource_creation(instance);
   if (resource_creation.failed())
     return;
 
   // Make the resource and get the API pointer to its interface.
   result->SetHostResource(
       instance, resource_creation.functions()->CreateVideoDecoder(
           instance, graphics_context.host_resource(), profile));
 }
 
 void PPB_VideoDecoder_Proxy::OnMsgDecode(
     const HostResource& decoder,
     const HostResource& buffer, int32 id, int32 size) {
-  pp::CompletionCallback callback = callback_factory_.NewRequiredCallback(
+  EnterHostFromHostResourceForceCallback<PPB_VideoDecoder_API> enter(
+      decoder, callback_factory_,
       &PPB_VideoDecoder_Proxy::SendMsgEndOfBitstreamACKToPlugin, decoder, id);
-
+  if (enter.failed())
+    return;
   PP_VideoBitstreamBuffer_Dev bitstream = { id, buffer.host_resource(), size };
-  ppb_video_decoder_target()->Decode(
-     decoder.host_resource(), &bitstream, callback.pp_completion_callback());
+  enter.SetResult(enter.object()->Decode(&bitstream, enter.callback()));
 }
 
 void PPB_VideoDecoder_Proxy::OnMsgAssignPictureBuffers(
     const HostResource& decoder,
     const std::vector<PP_PictureBuffer_Dev>& buffers) {
-  DCHECK(!buffers.empty());
-  const PP_PictureBuffer_Dev* buffer_array = &buffers.front();
-
-  ppb_video_decoder_target()->AssignPictureBuffers(
-      decoder.host_resource(), buffers.size(), buffer_array);
+  EnterHostFromHostResource<PPB_VideoDecoder_API> enter(decoder);
+  if (enter.succeeded() && !buffers.empty()) {
+    const PP_PictureBuffer_Dev* buffer_array = &buffers.front();
+    enter.object()->AssignPictureBuffers(buffers.size(), buffer_array);
+  }
 }
 
 void PPB_VideoDecoder_Proxy::OnMsgReusePictureBuffer(
     const HostResource& decoder, int32 picture_buffer_id) {
-  ppb_video_decoder_target()->ReusePictureBuffer(
-      decoder.host_resource(), picture_buffer_id);
+  EnterHostFromHostResource<PPB_VideoDecoder_API> enter(decoder);
+  if (enter.succeeded())
+    enter.object()->ReusePictureBuffer(picture_buffer_id);
 }
 
 void PPB_VideoDecoder_Proxy::OnMsgFlush(const HostResource& decoder) {
-  pp::CompletionCallback callback = callback_factory_.NewRequiredCallback(
+  EnterHostFromHostResourceForceCallback<PPB_VideoDecoder_API> enter(
+      decoder, callback_factory_,
       &PPB_VideoDecoder_Proxy::SendMsgFlushACKToPlugin, decoder);
-  ppb_video_decoder_target()->Flush(
-      decoder.host_resource(), callback.pp_completion_callback());
+  if (enter.succeeded())
+    enter.SetResult(enter.object()->Flush(enter.callback()));
 }
 
 void PPB_VideoDecoder_Proxy::OnMsgReset(const HostResource& decoder) {
-  pp::CompletionCallback callback = callback_factory_.NewRequiredCallback(
+  EnterHostFromHostResourceForceCallback<PPB_VideoDecoder_API> enter(
+      decoder, callback_factory_,
       &PPB_VideoDecoder_Proxy::SendMsgResetACKToPlugin, decoder);
-  ppb_video_decoder_target()->Reset(
-      decoder.host_resource(), callback.pp_completion_callback());
+  if (enter.succeeded())
+    enter.SetResult(enter.object()->Reset(enter.callback()));
 }
 
 void PPB_VideoDecoder_Proxy::OnMsgDestroy(const HostResource& decoder) {
-  ppb_video_decoder_target()->Destroy(decoder.host_resource());
+  EnterHostFromHostResource<PPB_VideoDecoder_API> enter(decoder);
+  if (enter.succeeded())
+    enter.object()->Destroy();
 }
 
 void PPB_VideoDecoder_Proxy::SendMsgEndOfBitstreamACKToPlugin(
     int32_t result, const HostResource& decoder, int32 id) {
   dispatcher()->Send(new PpapiMsg_PPBVideoDecoder_EndOfBitstreamACK(
       INTERFACE_ID_PPB_VIDEO_DECODER_DEV, decoder, id, result));
 }
 
 void PPB_VideoDecoder_Proxy::SendMsgFlushACKToPlugin(
     int32_t result, const HostResource& decoder) {
@@ skipping 23 matching lines @@
 
 void PPB_VideoDecoder_Proxy::OnMsgResetACK(
     const HostResource& decoder, int32_t result) {
   EnterPluginFromHostResource<PPB_VideoDecoder_API> enter(decoder);
   if (enter.succeeded())
     static_cast<VideoDecoder*>(enter.object())->ResetACK(result);
 }
 
 }  // namespace proxy
 }  // namespace ppapi