Issue 7873004: Merge 94964 - [chromium] REGRESSION(94353): Compositor textures and resources leaked when tab clo...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7873004: Merge 94964 - [chromium] REGRESSION(94353): Compositor textures and resources leaked when tab clo... (Closed)

Created:
9 years, 3 months ago by jamesr

Modified:
9 years, 3 months ago

Reviewers:
jamesr1

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/874/

Visibility:
Public.

Description

Merge 94964 - [chromium] REGRESSION(94353): Compositor textures and resources leaked when tab closed that is not last tab in the process https://bugs.webkit.org/show_bug.cgi?id=67816 Reviewed by Kenneth Russell. We lack infrastructure to construct an automated test for this today. To test manually, open up a composited page (like the poster circle), duplicate the tab many times, close all the duplicates, and verify that the memory use returns to the single tab level. * platform/graphics/chromium/LayerChromium.h: * platform/graphics/chromium/TiledLayerChromium.cpp: (WebCore::TiledLayerChromium::setLayerTreeHost): * platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::setLayerTreeHost): * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: (WebCore::CCLayerTreeHost::clearRenderSurfacesRecursive): (WebCore::CCLayerTreeHost::setRootLayer): * platform/graphics/chromium/cc/CCLayerTreeHost.h: TBR=jamesr@google.com BUG=96288 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94967

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4425 lines, -3 lines)			Patch
M	Source/WebCore/ChangeLog	View	2 chunks	+4400 lines, -0 lines	0 comments	Download
M	Source/WebCore/platform/graphics/chromium/LayerChromium.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/platform/graphics/chromium/VideoLayerChromium.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp	View	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages