content/common/gpu/gpu_channel_manager.cc - Issue 7870008: Wait properly for renderer crashes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/gpu_channel_manager.cc

Issue 7870008: Wait properly for renderer crashes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fixes Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/gpu_channel_manager.cc

diff --git a/content/common/gpu/gpu_channel_manager.cc b/content/common/gpu/gpu_channel_manager.cc

index 900e6ebb8b71670a8e5cf099723de4624fbc3174..5d3aba8c9e86321c12d6e8668684c63fed2347b0 100644

--- a/content/common/gpu/gpu_channel_manager.cc

+++ b/content/common/gpu/gpu_channel_manager.cc

@@ -102,9 +102,9 @@ void GpuChannelManager::OnEstablishChannel(int renderer_id) {

#if defined(OS_POSIX)

// On POSIX, pass the renderer-side FD. Also mark it as auto-close so

// that it gets closed after it has been sent.

- int renderer_fd = channel->GetRendererFileDescriptor();

+ int renderer_fd = channel->TakeRendererFileDescriptor();

DCHECK_NE(-1, renderer_fd);

- channel_handle.socket = base::FileDescriptor(dup(renderer_fd), true);

+ channel_handle.socket = base::FileDescriptor(renderer_fd, true);

#endif

}