Wait properly for renderer crashes

chrome/test/automation/automation_proxy.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_AUTOMATION_AUTOMATION_PROXY_H_
 #define CHROME_TEST_AUTOMATION_AUTOMATION_PROXY_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 205 matching lines @@
                        std::string* response) WARN_UNUSED_RESULT;
 
 #if defined(OS_CHROMEOS)
   // Logs in through the Chrome OS login wizard with given |username|
   // and |password|.  Returns true on success.
   bool LoginWithUserAndPass(const std::string& username,
                             const std::string& password) WARN_UNUSED_RESULT;
 #endif
 
 #if defined(OS_POSIX)
-  base::file_handle_mapping_vector fds_to_map() const;
+  int TakeClientFileDescriptor();

[darin (slow to review), 2011/09/15 05:43:37]

this method is a little bit odd here.  it isn't clear what ClientFileDescriptor
means in the context of the AutomationProxy.

you could name this method TakeClientFileDescriptorFromChannel, or perhaps you
should just expose a channel getter?

[Paweł Hajdan Jr., 2011/09/15 18:36:44]

Done.

 #endif
 
   // AutomationMessageSender implementation.
   virtual bool Send(IPC::Message* message) WARN_UNUSED_RESULT;
   virtual bool Send(IPC::Message* message, int timeout_ms) WARN_UNUSED_RESULT;
 
   // Wrapper over AutomationHandleTracker::InvalidateHandle. Receives the
   // message from AutomationProxy, unpacks the messages and routes that call to
   // the tracker.
   virtual void InvalidateHandle(const IPC::Message& message);
@@ skipping 70 matching lines @@
 
   // Delay to let the browser execute the command.
   base::TimeDelta action_timeout_;
 
   base::PlatformThreadId listener_thread_id_;
 
   DISALLOW_COPY_AND_ASSIGN(AutomationProxy);
 };
 
 #endif  // CHROME_TEST_AUTOMATION_AUTOMATION_PROXY_H_