Issue 7869009: Remove in-loop tracking for call ICs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7869009: Remove in-loop tracking for call ICs. (Closed)

Created:
9 years, 3 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 3 months ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Remove in-loop tracking for call ICs. We passed this flag around in a lot of places and had differenc call ICs based on it, but never did any real specialization based on its value. R=fschneider@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9260

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -291 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	5 chunks	+5 lines, -11 lines	0 comments	Download
M	src/arm/ic-arm.cc	View	3 chunks	+4 lines, -8 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/builtins.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/code-stubs.h	View	3 chunks	+5 lines, -15 lines	0 comments	Download
M	src/code-stubs.cc	View	3 chunks	+1 line, -8 lines	0 comments	Download
M	src/disassembler.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/full-codegen.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/handles.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/handles.cc	View	2 chunks	+1 line, -16 lines	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	5 chunks	+7 lines, -12 lines	0 comments	Download
M	src/ia32/ic-ia32.cc	View	3 chunks	+3 lines, -8 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	src/ic.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/ic.cc	View	16 chunks	+12 lines, -36 lines	0 comments	Download
M	src/objects.h	View	4 chunks	+7 lines, -12 lines	0 comments	Download
M	src/objects.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/objects-inl.h	View	5 chunks	+6 lines, -20 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+2 lines, -8 lines	0 comments	Download
M	src/stub-cache.h	View	9 chunks	+2 lines, -19 lines	0 comments	Download
M	src/stub-cache.cc	View	24 chunks	+14 lines, -67 lines	0 comments	Download
M	src/type-info.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/v8globals.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	5 chunks	+5 lines, -10 lines	0 comments	Download
M	src/x64/ic-x64.cc	View	3 chunks	+3 lines, -8 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Nice cleanup!

Expand Messages | Collapse Messages