Issue 7869: Apply Daniel's patch for array index strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7869: Apply Daniel's patch for array index strings. (Closed)

Created:
12 years, 2 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
kodandersson, bak

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Apply Daniel's patch for array index strings. Committed: http://code.google.com/p/v8/source/detail?r=560

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -14 lines)			Patch
M	AUTHORS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ic-ia32.cc	View	3 chunks	+15 lines, -4 lines	0 comments	Download
M	src/objects.h	View	3 chunks	+5 lines, -2 lines	0 comments	Download
M	src/objects.cc	View	3 chunks	+17 lines, -6 lines	1 comment	Download
M	src/objects-inl.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bak

LGTM, Lars http://codereview.chromium.org/7869/diff/1/4 File src/objects.cc (right): http://codereview.chromium.org/7869/diff/1/4#newcode3922 Line 3922: Hash(); // force computation of hash ...

12 years, 2 months ago (2008-10-22 13:25:14 UTC) #2

LGTM

Expand Messages | Collapse Messages