Issue 7868: Rename member variables and functions and clarify comments to try to...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7868: Rename member variables and functions and clarify comments to try to... (Closed)

Created:
12 years, 2 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
iposva, Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Rename member variables and functions and clarify comments to try to make the operation of LabelShadows more understandable. Committed: http://code.google.com/p/v8/source/detail?r=556

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -51 lines)			Patch
M	src/assembler.h	View	3 chunks	+22 lines, -15 lines	1 comment	Download
M	src/codegen-arm.cc	View	8 chunks	+33 lines, -19 lines	1 comment	Download
M	src/codegen-ia32.cc	View	8 chunks	+30 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

This is only renaming and comment changes.

12 years, 2 months ago (2008-10-22 12:17:29 UTC) #1

iposva

12 years, 2 months ago (2008-10-22 18:34:33 UTC) #3

Some more nits. Since this is all about readability...

-Ivan

http://codereview.chromium.org/7868/diff/1/2
File src/assembler.h (right):

http://codereview.chromium.org/7868/diff/1/2#newcode51
Line 51: class Label : public ZoneObject {  // ShadowedLabels are dynamically
allocated.
ShadowedLabels reads like a C++ class to me. You probably meant to either say
"shadowed Labels or "LabelShadows" here.

http://codereview.chromium.org/7868/diff/1/3
File src/codegen-arm.cc (right):

http://codereview.chromium.org/7868/diff/1/3#newcode1638
Line 1638: // returns. During shadowing, the origianl label is hidden as the
origianl -> original

Expand Messages | Collapse Messages