Introduce AudioDecoderConfig to migrate away from GetAVStream().

media/base/audio_decoder_config.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MEDIA_BASE_AUDIO_DECODER_CONFIG_H_
+#define MEDIA_BASE_AUDIO_DECODER_CONFIG_H_
+
+#include "base/basictypes.h"
+#include "base/memory/scoped_ptr.h"
+#include "media/base/channel_layout.h"
+#include "media/base/media_export.h"
+
+namespace media {
+
+enum AudioCodec {
+  kUnknownAudioCodec,
+  kCodecAAC,
+  kCodecMP3,
+  kCodecPCM,
+  kCodecVorbis,
+
+  // DO NOT ADD RANDOM AUDIO CODECS!
+  //
+  // The only acceptable time to add a new codec is if there is production code
+  // that uses said codec in the same CL.
+};
+
+class MEDIA_EXPORT AudioDecoderConfig {
+ public:
+  AudioDecoderConfig(AudioCodec codec, int bits_per_channel,
+                     ChannelLayout channel_layout, int sample_rate,
+                     const uint8* extra_data, size_t extra_data_size);

[Ami GONE FROM CHROMIUM, 2011/09/12 20:54:21]

Document (lack of) ownership semantics of |extra_data|

[scherkus (not reviewing), 2011/09/19 21:19:45]

Done.

+  ~AudioDecoderConfig();
+
+  AudioCodec codec() const;
+  int bits_per_channel() const;
+  ChannelLayout channel_layout() const;
+  int sample_rate() const;
+  uint8* extra_data() const;
+  size_t extra_data_size() const;
+
+ private:
+  AudioCodec codec_;
+  int bits_per_channel_;
+  ChannelLayout channel_layout_;
+  int sample_rate_;

[Ami GONE FROM CHROMIUM, 2011/09/12 20:54:21]

comment units?

[scherkus (not reviewing), 2011/09/19 21:19:45]

This is typically understood to be in Hz but we could rename the variable to be
samples_per_second_

WDYT?

[Ami GONE FROM CHROMIUM, 2011/09/20 20:34:50]

I like that.

+
+  // Optional byte data required to initialize audio decoders.

[Ami GONE FROM CHROMIUM, 2011/09/12 20:54:21]

Examples?
Comment might be more useful on public accessors, not private impl.

[scherkus (not reviewing), 2011/09/19 21:19:45]

Done.

+  scoped_array<uint8> extra_data_;
+  size_t extra_data_size_;
+
+  DISALLOW_IMPLICIT_CONSTRUCTORS(AudioDecoderConfig);
+};
+
+}  // namespace media
+
+#endif  // MEDIA_BASE_AUDIO_DECODER_CONFIG_H_