Issue 7867045: [ntp4] Improve styling for bookmarks header bar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7867045: [ntp4] Improve styling for bookmarks header bar. (Closed)

Created:
9 years, 3 months ago by csilv

Modified:
9 years, 3 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[ntp4] Improve styling for bookmarks header bar. BUG=94968 TEST=Visual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100724

Patch Set 4 : code review update #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -13 lines)			Patch
M	chrome/browser/resources/ntp4/bookmarks_page.css	View	1 2 3	2 chunks	+3 lines, -12 lines	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab.html	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab_theme.css	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

lgtm http://codereview.chromium.org/7867045/diff/3001/chrome/browser/resources/ntp4/bookmarks_page.css File chrome/browser/resources/ntp4/bookmarks_page.css (right): http://codereview.chromium.org/7867045/diff/3001/chrome/browser/resources/ntp4/bookmarks_page.css#newcode113 chrome/browser/resources/ntp4/bookmarks_page.css:113: border-bottom-width: 1px; I think you can still put ...

9 years, 3 months ago (2011-09-12 17:42:55 UTC) #2

csilv

9 years, 3 months ago (2011-09-12 18:11:55 UTC) #3

http://codereview.chromium.org/7867045/diff/3001/chrome/browser/resources/ntp...
File chrome/browser/resources/ntp4/bookmarks_page.css (right):

http://codereview.chromium.org/7867045/diff/3001/chrome/browser/resources/ntp...
chrome/browser/resources/ntp4/bookmarks_page.css:113: border-bottom-width: 1px;
On 2011/09/12 17:42:55, Evan Stade wrote:
> I think you can still put this on one line, just like it was just omit the
> color.

Done.

Expand Messages | Collapse Messages

Issue 7867045: [ntp4] Improve styling for bookmarks header bar. (Closed)

Description

Patch Set 1 #

Patch Set 2 : tweak #

Patch Set 3 : moar tweaking #

Patch Set 4 : code review update #

Messages