chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h - Issue 7867044: PART1: Initiated the SignedSettings refactoring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h

Issue 7867044: PART1: Initiated the SignedSettings refactoring. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments from Chris and rebased to ToT to get it running on the try servers again. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc ('K') | « chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc ('k') | chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h

diff --git a/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h b/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h

index 6c18fe0ed99c1eb54c4810e00e2f4656bc372d51..bbcdeae6d89138e1262f0d8495650df8227d5747 100644

--- a/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h

+++ b/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h

@@ -17,10 +17,10 @@ class CoreChromeOSOptionsHandler : public CoreOptionsHandler {

protected:

// ::CoreOptionsHandler overrides

- virtual Value* FetchPref(const std::string& pref_name);

+ virtual base::Value* FetchPref(const std::string& pref_name);

Mattias Nissler (ping if slow) 2011/10/13 13:41:06 nit: OVERRIDE

pastarmovj 2011/10/26 15:43:19 Done throughout the whole file.

virtual void ObservePref(const std::string& pref_name);

virtual void SetPref(const std::string& pref_name,

- const Value* value,

+ const base::Value* value,

const std::string& metric);

virtual void StopObservingPref(const std::string& path);