Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chrome/browser/chromeos/login/user_controller_unittest.cc

Issue 7867044: PART1: Initiated the SignedSettings refactoring. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments from Chris and rebased to ToT to get it running on the try servers again. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/user_controller_unittest.cc
diff --git a/chrome/browser/chromeos/login/user_controller_unittest.cc b/chrome/browser/chromeos/login/user_controller_unittest.cc
index 6b8ce18e8949a42780a2d93cfc66a4fe589069da..eeb494936ac0a0e02d2f3bce8fd77a9fc6f80e0c 100644
--- a/chrome/browser/chromeos/login/user_controller_unittest.cc
+++ b/chrome/browser/chromeos/login/user_controller_unittest.cc
@@ -25,10 +25,15 @@ TEST(UserControllerTest, GetNameTooltipIncognitoUser) {
new_user_controller.GetNameTooltip());
}
-TEST(UserControllerTest, GetNameTooltipExistingUser) {
+TEST(UserControllerTest, DISABLED_GetNameTooltipExistingUser) {
Mattias Nissler (ping if slow) 2011/10/13 13:41:06 I feel bad disabling a test here. Can we maybe jus
pastarmovj 2011/10/26 15:43:19 I reenable this test in PART6 where all the needed
// We need to have NotificationService and g_browser_process initialized
// before we create UserController for existing user.
// Otherwise we crash with either SEGFAULT or DCHECK.
+ // There used to be a rather unpleasant workaround in UserCrosSettingsProvider
+ // to prevent the trash in this test which I removed thus I have disabled the
+ // test.
+ // TODO(pastarmovj): If we really want to keep this particular test it should
+ // be made browser test I think.
UserManager::User existing_user;
existing_user.set_email("someordinaryuser@domain.com");
UserController existing_user_controller(NULL, existing_user);

Powered by Google App Engine
This is Rietveld 408576698