Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3315)

Unified Diff: chrome/browser/chromeos/login/google_authenticator.h

Issue 7867044: PART1: Initiated the SignedSettings refactoring. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed the comments from Denis. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/google_authenticator.h
diff --git a/chrome/browser/chromeos/login/google_authenticator.h b/chrome/browser/chromeos/login/google_authenticator.h
index 6d38e113ba0deb39b9f825b4043951910f6bf459..cf0f6ef234a6f0b56cf83d875086f11721de74e4 100644
--- a/chrome/browser/chromeos/login/google_authenticator.h
+++ b/chrome/browser/chromeos/login/google_authenticator.h
@@ -47,7 +47,7 @@ class GoogleAuthenticator : public Authenticator, public GaiaAuthConsumer {
// of authentication cookies or a callback to consumer_->OnLoginFailure() with
// an error message.
// Returns true if the attempt gets sent successfully and false if not.
- virtual bool CompleteLogin(Profile* profile,
+ virtual void CompleteLogin(Profile* profile,
const std::string& username,
const std::string& password) OVERRIDE;
@@ -64,7 +64,7 @@ class GoogleAuthenticator : public Authenticator, public GaiaAuthConsumer {
// call OnLoginFailure() with HOSTED_NOT_ALLOWED.
//
// Returns true if the attempt gets sent successfully and false if not.
- virtual bool AuthenticateToLogin(Profile* profile,
+ virtual void AuthenticateToLogin(Profile* profile,
const std::string& username,
const std::string& password,
const std::string& login_token,

Powered by Google App Engine
This is Rietveld 408576698