Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1875)

Unified Diff: chrome/browser/chromeos/login/authenticator.h

Issue 7867044: PART1: Initiated the SignedSettings refactoring. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed the comments from Denis. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/authenticator.h
diff --git a/chrome/browser/chromeos/login/authenticator.h b/chrome/browser/chromeos/login/authenticator.h
index 7e404405a886e21b779c79e42c44900c9f0b33a5..6df0d9e11a4cc91ff2cdce617f05bbbd6e7ce018 100644
--- a/chrome/browser/chromeos/login/authenticator.h
+++ b/chrome/browser/chromeos/login/authenticator.h
@@ -31,17 +31,15 @@ class Authenticator : public base::RefCountedThreadSafe<Authenticator> {
// Given externally authenticated |username| and |password|, this method
// attempts to complete authentication process.
- // Returns true if the attempt gets sent successfully and false if not.
- virtual bool CompleteLogin(Profile* profile,
+ virtual void CompleteLogin(Profile* profile,
const std::string& username,
const std::string& password) = 0;
// Given a |username| and |password|, this method attempts to authenticate
// to login.
// Optionally |login_token| and |login_captcha| could be provided.
- // Returns true if we kick off the attempt successfully and false if we can't.
// Must be called on the UI thread.
- virtual bool AuthenticateToLogin(Profile* profile,
+ virtual void AuthenticateToLogin(Profile* profile,
const std::string& username,
const std::string& password,
const std::string& login_token,

Powered by Google App Engine
This is Rietveld 408576698