Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: chrome/browser/chromeos/cros_settings_provider.h

Issue 7867044: PART1: Initiated the SignedSettings refactoring. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed the comments from Denis. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/cros_settings_provider.h
diff --git a/chrome/browser/chromeos/cros_settings_provider.h b/chrome/browser/chromeos/cros_settings_provider.h
index 002a2b05b8d84784591f1e0955a0a43610fa6af4..9c28d660e418bce062a2d73cb07e44ca7810928b 100644
--- a/chrome/browser/chromeos/cros_settings_provider.h
+++ b/chrome/browser/chromeos/cros_settings_provider.h
@@ -7,6 +7,8 @@
#include <string>
+#include "base/callback.h"
+
namespace base {
class Value;
}
@@ -17,13 +19,21 @@ class CrosSettingsProvider {
public:
virtual ~CrosSettingsProvider() {}
+ // Callback function type.
+ typedef base::Closure Callback;
+
// Sets |in_value| to given |path| in cros settings.
// Note that this takes ownership of |in_value|.
void Set(const std::string& path, base::Value* in_value);
// Gets settings value of given |path| to |out_value|.
// Note that |out_value| is owned by the caller, not this class.
Mattias Nissler (ping if slow) 2011/09/21 11:12:59 Is there a technical reason for this? The interfac
pastarmovj 2011/09/23 15:19:32 Obsolete comment it doesn't really. Removed. This
- virtual bool Get(const std::string& path, base::Value** out_value) const = 0;
+ virtual const base::Value* Get(const std::string& path) const = 0;
+
+ // Starts a fetch from the trusted store for the value of |path|. It will
+ // call the |callback| function upon completion.
+ virtual bool GetTrusted(const std::string& path,
+ const Callback& callback) const = 0;
// Gets the namespace prefix provided by this provider
virtual bool HandlesSetting(const std::string& path) const = 0;

Powered by Google App Engine
This is Rietveld 408576698